Uniformize SOCMAKE_SIM_RUN_CMD and add SOCMAKE_SIM_RUN_DIR#212
Open
mtravaillard wants to merge 2 commits into
Open
Uniformize SOCMAKE_SIM_RUN_CMD and add SOCMAKE_SIM_RUN_DIR#212mtravaillard wants to merge 2 commits into
mtravaillard wants to merge 2 commits into
Conversation
mtravaillard
added
the
trigger-gitlab-testing
Contributor
|
@Risto97 can we merge this? I did some test on my side and it seems to be fine (i.e., I can easily adapt my flow to this), but it would be more widely tested once merged into develop, so I would be for merging and updated it later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed SIM_RUN_CMD to SOCMAKE_SIM_RUN_CMD where it was not done.
Remove
cd ${OUTDIR}from SOCMAKE_SIM_RUN_CMD.Add SOCMAKE_SIM_RUN_DIR to forward the
OUTDIRinformation.