Questasim fix exit codes#209
Merged
Merged
Conversation
…al(), $error(), ...
Risto97
added
the
trigger-gitlab-testing
Contributor
mtravaillard
left a comment
mtravaillard
left a comment
There was a problem hiding this comment.
I don't use Questa but it worked correctly on the CI, for 3 different versions of the tool.
Do you think it would be useful to add the DO_FILES argument to other tools (vcs, xcelium ...) or it's not relevant ? Currently they don't use/need do run -all like we do with Questa.
Contributor
Author
|
The other simulators work differently, and I am not sure if its possible to pass tcl scripts when running. I will test it a bit more and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questasim does not propagate the exit codes to the CLI after it executes the testbench.
It means that the calls like
$fatal(), $error()are ignored by the simulator and not forwarded to the shell.This leads to difficulties in CI flows as we cannot rely on the exit codes, even if the
$fatal()was called the exit code can still be0.This pull request should fix that by using a default
run.doscript instead of inlinetcl.I also added the
DO_FILESargument toquestasimso that user can pass any number of tcl scripts to execute in place of the default ones.@mtravaillard can you please check if this breaks any of your flows (in case you use questa), or internal CI pipelines.