Skip to content

Wrong order of default installation parameters for msiexec #654

@dryzhov

Description

@dryzhov

Steps to reproduce:

  1. create software installation recipe without definition of flags
  2. launch recipe

Result: msiexec dialog window with usage information

Expected result: installed msi package

Analyze:
Function policies/recipes/steps.go/stepInstallMsi contains code with default msiexec options

   args := step.Flags
   if len(args) == 0 {
   	args = []string{"/i", "/qn", "/norestart"}
   }
   args = append(args, path)

where path contain full path to *.msi file

By msiexec documentation parameter /i must contain value - package or product code. Then code may look like this:

	args := step.Flags
	if len(args) == 0 {
		args = []string{"/qn", "/norestart", "/i"}
	}
	args = append(args, path)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions