Plugin color configs reset

[remi-gelinas]

Mostly just as an FYI, but I had to check the commit history to see what went wrong with my path marker colors. With this change now on the plugin hub, updating the plugin will reset all your colors instead of properly migrating old config options to their new counterparts.

[mastersuleman]

oh noooooo

[remi-gelinas]

@mastersuleman I mean yeah, is it functionally breaking the plugin? No, of course not - but best practice is to either migrate old configs to new, or create new config options and copy old ones into it to make migration easy for users. If anyone else gets confused as to where their colors went, they can find the answer here :)

[GeChallengeM]

I was aware of this, but don't know how to migrate old configs to new. Only the tile colors were affected, nothing else. Also, I figured that this would get people to check the plugin's settings again to notice the new color settings, allowing them to customize it better than before.

But yeah, sorry for the inconvenience. If you have any tips for how to migrate old configs to new, feel free to let me know, so this won't happen again.

[remi-gelinas]

@GeChallengeM Like I said, it's not like it's a functionally breaking change. I just wanted some visibility for users who want to know why their colors reset :D

As for migration, Dilly actually does a great job with the version comparison mechanism in Inventory Setups. He generates plugin versions in his jar, and then saves the current version in his config (code to fetch/save here). He then compares it in his main panel here, and updates the version string in the config when the update panel is dismissed.

A similar solution could be used here, but instead of using the version comparison to show a panel, just run a migration to get the old settings and set the new settings to the old values, if applicable. You could set this up for existing users by checking for the absence of the current version config key for now as well, since you don't have the current version in the plugin config in the current version.

Just my 2 cents though - at the end of the day, whether you anticipate enough breaking changes to actually implement this is up to you!

[mastersuleman]

Honestly, I love the plugin, its amazing. Its not a big deal that the settings got wiped. Thanks for the plugin

[N19htfox]

Sorry about the inconvenience guys. There was a highly requested feature that required renaming a couple of the config variables. If I get a chance I'll take a look at remi-gelinas's suggestion and maybe work on an implementation in my fork. Thank you all for feedback!