Skip to content

Get rid of CWallet::OrderedTxItems and keep wallet transactions in memory always ordered #579

@dimxy

Description

@dimxy

Currently transactions in wallet's memory are ordered on purpose in OrderedTxItems. Also each in call to OrderedTxItems a walletdb is created which may take thousands of milliseconds. This especially affects importprivkey rpc.
The fix should remove OrderedTxItems() method and always keep transactions ordered.
When implementing avoid creating CWalletDB inside loops.

See also zcash@31d49b0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions