Feature Request: Add Amount per crate to rust companion / http server

[HaasCM]

Heyo!

I've been playing around with the http server & companion a tad bit, I noticed it's lacking the Quantity per crate. Was wondering if adding some of the "ItemDynamicData" is something you're open to?

I'm thinking of changing the object structure of the "contents" array from:

    {
      "icon": {
        "bounds": {
          "x": 14,
          "y": 34,
          "width": 32,
          "height": 32
        },
        "code_name": "SoldierSupplies",
        "is_crated": true
      },
      "quantity": {
        "bounds": {
          "x": 58,
          "y": 34,
          "width": 42,
          "height": 32
        },
        "label": "20",
        "value": 20
      }
    },

to something like:

    {
      "icon": {
        "bounds": {
          "x": 14,
          "y": 34,
          "width": 32,
          "height": 32
        },
        "code_name": "SoldierSupplies",
        "is_crated": true
      },
      "quantity": {
        "bounds": {
          "x": 58,
          "y": 34,
          "width": 42,
          "height": 32
        },
        "label": "20",
        "value": 20
      },
    "ItemData": {
        "QuantityPerCrate": 20
    },

Could also add more to the ItemData body as use cases arise.

I believe this will allow clients the ability to determine the uncrated value, even when an item is created. Thoughts?

[HaasCM]

FWIW, I'm hacking away at a PR for this right now, basically reading the json like ICON_CLASS_NAMES_JSON and QUANTITY_CLASS_NAMES_JSON, then changed the function signature of

pub fn extract_stockpile(
    rgba: &[u8],
    width: usize,
    ocr: &Ocr,
    icon_classifier: &mut Classifier,
    quantity_classifier: &mut Classifier,
)

to

pub fn extract_stockpile(
    rgba: &[u8],
    width: usize,
    ocr: &Ocr,
    icon_classifier: &mut Classifier,
    quantity_classifier: &mut Classifier,
    catalog: &serde_json::Value,
)

So that when the json object is created in this function information can be pulled from the catalog as needed. Got it most of the way there. I'm just running into an issue with implementing it this way in the wasm library. I'm not too familiar with rust, so learning as I go.

[HaasCM]

Lemme know if you've got a better idea for implementation.

[GICodeWarrior]

How about an attributes: Optional<HashMap<String, serde_json::Value>> property on Entry, and a query parameter on the API (e.g. ?include=quantity_per_crate) that determines what to include?

There could be an attribute lookup struct defined in shared that's constructed with the catalog, has a method that given a &[str] and a &mut Entry will fill the entry with the given attributes, and calls a separate method to process each attribute.

That way, different use cases can request different attributes, and the catalog can be ignored altogether when not needed.

Also, maybe you want uncrated_quantity instead of quantity_per_crate since you're operating on individual entries.

[GICodeWarrior]

I made a few tweaks and merged your PR. Please let me know if you have any questions or concerns.

Thanks for contributing!