Skip to content
This repository was archived by the owner on May 29, 2023. It is now read-only.
This repository was archived by the owner on May 29, 2023. It is now read-only.

Make Server class more extensible #49

@abner

Description

@abner

I would like to have the option to extend or enhance some aspects of the Server class.
Like change the visibility of some methods to protected, like

private Single<JsonObject> loadConfig(JsonObject config) {
...

so i would merge with another ConfigRetriever strategies, like merge with environment variables.

Another change i propose is have a method to enhance VertxOptions, because when using Dropwizard Metrics, we can set a baseName to the metrics, but at this time DropwizarMetricsOptions does not pickup this from the configFile, so the only way is set it directly through the vertxOptions.metricsOptions object.

I will apply these changes to the Server class and i do have plans to submit this PR soon.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions