Skip to content

Code Review 2/24/2026 - Robot.java #17

@rmaizel

Description

@rmaizel

Robot.java - main branch

lines 49-54

  private static Robot   instance;
  Compressor compressor = new Compressor(PneumaticsModuleType.REVPH);
[...]
  private Timer disabledTimer;

Why are these lines here? What does Robot instance; do? Do we still need Timer disabledTimer;? Is the Compressor what we're using for our PCM?

lines 104-106 & 112-114

      Logger.recordMetadata("ProjectName", "MyProject"); // Set a metadata value
      Logger.addDataReceiver(new NT4Publisher()); // Publish data to NetworkTables
      Logger.start();

This block of code is repeated at lines 104 and 112 - they are EXACTLY the same. Is this intentional? If not we should take out one of the two sets of this code.

lines 164-169

  public void teleopPeriodic() {
    //taking out bc we just used actuatorPositionEntry.getDouble instead of using variable
    // double actuatorPosition = actuatorPositionEntry.getDouble(0);

        
  }

We can remove these comments at this point. Go ahead and clean it up.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions