Updates to Constants needed

[rmaizel]

Constants.java needs some minor style corrections and comments.

For this section...

public static final double BlueHubX = 4.597;
public static final double RedHubX = 11.938;
public static final double HubY = 4.035;

public static final double TOPCORNERY = 7.55; //top in choreo with blue on left
public static final double BOTTOMCORNERY = 0.5;
public static final double BLUECORNERX = 0.5;
public static final double REDCORNERX = 16.1;

public static final double AlignTolerance = 1.0; //deg

• Constants should be presented in ALL_CAPS with words SPACED_BY_UNDERSCORES
• Add a comment or doc-block for what each group of constants is for, if it's not in its own sub-class
• Some of these are not clear from the name what they do, add a line comment or change the constant name

For DrivebaseConstants

public static double DriveFastScale = 1;
public static double DrivePrecisionScale = 0.35;

• Clarify if these are variables or constants
• If Constants, adjust names and modifiers accordingly (ALL_CAPS and "final", respectively)
• If Variables, move to the Swerve subsystem

[rmaizel]

@JosephMurdockCoding: please close this issue when you've made these edits.