From 471dfd111646aaf42b278af6f1a35264846a9bbb Mon Sep 17 00:00:00 2001 From: Francois LaBerge Date: Wed, 5 Mar 2025 23:17:21 -0500 Subject: [PATCH 1/4] ad permissions --- .github/workflows/pr.yaml | 5 ++++- .github/workflows/release-staging.yaml | 3 +++ .github/workflows/release.yaml | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index b6f54b2..3667166 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -1,6 +1,9 @@ name: Pull Request Checks -on: [ push ] +on: + push: + branches: + - !main jobs: code-quality: diff --git a/.github/workflows/release-staging.yaml b/.github/workflows/release-staging.yaml index 971a5af..db0f479 100644 --- a/.github/workflows/release-staging.yaml +++ b/.github/workflows/release-staging.yaml @@ -14,5 +14,8 @@ jobs: uses: ./.github/workflows/test.yaml publish: name: Publish staging release + permissions: + id-token: write + pages: write uses: ./.github/workflows/publish-test.yaml needs: [code-quality, test] diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index ec42296..f993628 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -8,4 +8,6 @@ on: jobs: publish: name: Publish release + permissions: + id-token: write uses: ./.github/workflows/publish.yaml From e0676d25d2d6ce2dcbca42c1122dee6647133b92 Mon Sep 17 00:00:00 2001 From: Francois LaBerge Date: Wed, 5 Mar 2025 23:25:43 -0500 Subject: [PATCH 2/4] change triggers for pr and test release --- .github/workflows/pr.yaml | 7 +++++-- .github/workflows/release-staging.yaml | 4 +++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 3667166..8d4ef32 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -1,9 +1,12 @@ name: Pull Request Checks on: - push: + pull_request: + types: + - opened + - reopened branches: - - !main + - main jobs: code-quality: diff --git a/.github/workflows/release-staging.yaml b/.github/workflows/release-staging.yaml index db0f479..82d545c 100644 --- a/.github/workflows/release-staging.yaml +++ b/.github/workflows/release-staging.yaml @@ -1,7 +1,9 @@ name: Release on Staging on: - push: + pull_request: + types: + - closed branches: - main From 12c94d742ffb23ee465d84d7d9c5fc4362e4f1c4 Mon Sep 17 00:00:00 2001 From: Francois LaBerge Date: Wed, 5 Mar 2025 23:27:10 -0500 Subject: [PATCH 3/4] remove types --- .github/workflows/pr.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 8d4ef32..03f76bc 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -2,9 +2,6 @@ name: Pull Request Checks on: pull_request: - types: - - opened - - reopened branches: - main From 78b69660d505c764baf18b97f7b60e5844c7c08c Mon Sep 17 00:00:00 2001 From: Francois LaBerge Date: Wed, 5 Mar 2025 23:30:28 -0500 Subject: [PATCH 4/4] remove space --- .github/workflows/test.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index aa6ae4e..1d02d95 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -5,7 +5,6 @@ on: jobs: unit-test: - runs-on: ubuntu-latest strategy: matrix: