From f5598d9f793478a297142f5ad91664beb5df9463 Mon Sep 17 00:00:00 2001
From: Zahra Gholami <gholami.zah79@gmail.com>
Date: Tue, 31 Mar 2026 17:35:39 +0900
Subject: [PATCH] Remove local secrets volume from docker-compose.yml and
 simplify optional value handling in SamplePageService.java

---
 docker-compose.yml                                        | 2 --
 .../uk/ac/ebi/biosamples/service/SamplePageService.java   | 8 ++------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/docker-compose.yml b/docker-compose.yml
index b4a20ccca..698de2fc3 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -13,7 +13,6 @@ services:
     - schema-store
     volumes:
     - logs:/logs
-    - "/mnt/c/Users/dgupta/secrets:/secrets"
     command:
     - java
     - -jar
@@ -101,7 +100,6 @@ services:
       - rabbitmq
     volumes:
       - logs:/logs
-      - "/mnt/c/Users/dgupta/secrets:/secrets"
     command:
       - java
       - -jar
diff --git a/webapps/core/src/main/java/uk/ac/ebi/biosamples/service/SamplePageService.java b/webapps/core/src/main/java/uk/ac/ebi/biosamples/service/SamplePageService.java
index daca984ae..15cb77ffd 100644
--- a/webapps/core/src/main/java/uk/ac/ebi/biosamples/service/SamplePageService.java
+++ b/webapps/core/src/main/java/uk/ac/ebi/biosamples/service/SamplePageService.java
@@ -99,11 +99,7 @@ public Page<Sample> getSamplesByText(
         pageFutureSample.map(
             ss -> {
               try {
-                if (ss.get().isPresent()) {
-                  return ss.get().get();
-                } else {
-                  return null;
-                }
+                return ss.get().orElse(null);
               } catch (final InterruptedException | ExecutionException e) {
                 throw new RuntimeException(e);
               }
@@ -143,7 +139,7 @@ private List<Sample> collectSampleFutures(final List<Future<Optional<Sample>>> l
         .map(
             ss -> {
               try {
-                return ss.get().get();
+                return ss.get().orElse(null);
               } catch (final InterruptedException | ExecutionException e) {
                 throw new RuntimeException(e);
               }