From 8fd48ebca76bf5735a01af3256daecf2cf9697ff Mon Sep 17 00:00:00 2001 From: Parth Dagia Date: Sat, 18 Apr 2026 10:58:27 +0530 Subject: [PATCH] fix: remove dead-code exception handlers leaking stack traces (#449) Remove 'except(IOError): raise IOError' blocks from three route endpoints. Since IOError is an alias for OSError in Python 3.3+, the raise inside the first except propagated out and made the subsequent 'except OSError' JSON error handlers unreachable dead code. Clients received raw 500 stack traces instead of structured JSON error responses. Affected endpoints: - /copyCase (CaseRoute.py) - uploadCaseUnchunked_old (UploadRoute.py) - uploadXls (UploadRoute.py) Closes #449 --- API/Routes/Case/CaseRoute.py | 2 -- API/Routes/Upload/UploadRoute.py | 4 ---- 2 files changed, 6 deletions(-) diff --git a/API/Routes/Case/CaseRoute.py b/API/Routes/Case/CaseRoute.py index a3684cd67..21b23cf65 100644 --- a/API/Routes/Case/CaseRoute.py +++ b/API/Routes/Case/CaseRoute.py @@ -103,8 +103,6 @@ def copy(): "status_code": "success" } return jsonify(response), 200 - except(IOError): - raise IOError except OSError: return jsonify({'message': 'A filesystem error occurred.', 'status_code': 'error'}), 500 diff --git a/API/Routes/Upload/UploadRoute.py b/API/Routes/Upload/UploadRoute.py index 4d451c37b..14944396b 100644 --- a/API/Routes/Upload/UploadRoute.py +++ b/API/Routes/Upload/UploadRoute.py @@ -399,8 +399,6 @@ def uploadCaseUnchunked_old(): } return jsonify(response), 200 - except(IOError): - raise IOError except OSError: return jsonify({'message': 'A filesystem error occurred.', 'status_code': 'error'}), 500 @@ -649,7 +647,5 @@ def uploadXls(): } return jsonify(response), 200 - except(IOError): - raise IOError except OSError: return jsonify({'message': 'A filesystem error occurred.', 'status_code': 'error'}), 500 \ No newline at end of file