@Devnil434 Where: reason = "Repeated keypad interaction over 22s ..." and timestamp_ms = 1718000022000.0
What's wrong:
- 1718000022000 ms = Unix epoch 22.000 seconds past 1718000000000. This makes it look intentional — but if Phase 5 alert endpoints compute duration dynamically from timestamp_ms - event_start_ms and compare it against the text in reason for audit logging or NLP assertion tests, the 22s in the string becomes a magic number coupled to the timestamp. If any test changes timestamp_ms for a different scenario (e.g. testing midnight boundary), the reason string silently lies. The fixture creates an invisible coupling between two independent fields.
Fix:
-
Decouple the duration from the timestamp
- reason = "Repeated keypad interaction over extended period suggests unauthorised entry attempt."
-
Duration should be derived at runtime, not hardcoded into a fixture string
@Devnil434 Where: reason = "Repeated keypad interaction over 22s ..." and timestamp_ms = 1718000022000.0
What's wrong:
Fix:
Decouple the duration from the timestamp
Duration should be derived at runtime, not hardcoded into a fixture string