Skip to content

docs(cv-v2): fix two stale Javadoc references from migration review #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DemchaAV merged 1 commit into from
May 28, 2026
Merged

docs(cv-v2): fix two stale Javadoc references from migration review #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/java/com/demcha/compose/document/templates/cv/v2/theme/CvSpacing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,11 @@ public static CvSpacing sidebarPortrait() {

/**
* Spacing for the Monogram Sidebar preset: zero page-flow gap so
* the pale sidebar fill bleeds edge-to-edge against the
* RECOMMENDED_MARGIN=0 page bounds. Banner tokens are unused —
* the preset draws its visual chrome inline (monogram badge, rules,
* filler shape).
* the content sits flush against the RECOMMENDED_MARGIN=0 page
* bounds. The pale sidebar fill is painted edge-to-edge on every
* page by {@code DocumentSession.pageBackgrounds(...)}, not by this
* spacing; banner tokens are unused — the preset only draws the
* monogram badge and sidebar heading rules inline.
*/
public static CvSpacing monogramSidebar() {
return new CvSpacing(
Expand Down
5 changes: 4 additions & 1 deletion src/test/java/com/demcha/compose/document/templates/cv/v2/presets/PanelSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
* Smoke test for the v2 Panel preset. Covers the header card with
* optional job title + link row, plus the two-column row composition
* fed through {@link com.demcha.compose.document.templates.cv.v2.components.SectionLookup}
* and {@link com.demcha.compose.document.templates.cv.v2.components.SectionDispatcher}.
* and the preset-local body dispatcher (Panel renders its own
* row-free dispatch because each card sits inside {@code flow.addRow},
* which the engine forbids from containing nested rows — so it cannot
* delegate to the shared {@code SectionDispatcher}).
*/
class PanelSmokeTest {

Expand Down