From fa3cb6b0f6ee6a9dd6dfcc1e51b64b6e90d8a052 Mon Sep 17 00:00:00 2001 From: DemchaAV Date: Thu, 28 May 2026 10:29:01 +0100 Subject: [PATCH] docs(cv-v2): fix two stale Javadoc references flagged by migration review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * CvSpacing.monogramSidebar() Javadoc claimed the preset "draws its visual chrome inline (... filler shape)" — stale. MonogramSidebar paints the sidebar fill via DocumentSession.pageBackgrounds(...) on every page; the filler shape was removed. Reworded to describe the pageBackgrounds chrome accurately. * PanelSmokeTest Javadoc @link'd SectionDispatcher, but Panel renders its own row-free body dispatcher (cards sit inside flow.addRow, which the engine forbids from containing nested rows). Updated the doc to describe the preset-local dispatcher and the reason. Comment-only — no behaviour or render change. --- .../document/templates/cv/v2/theme/CvSpacing.java | 9 +++++---- .../document/templates/cv/v2/presets/PanelSmokeTest.java | 5 ++++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/demcha/compose/document/templates/cv/v2/theme/CvSpacing.java b/src/main/java/com/demcha/compose/document/templates/cv/v2/theme/CvSpacing.java index f9115695..03ab942c 100644 --- a/src/main/java/com/demcha/compose/document/templates/cv/v2/theme/CvSpacing.java +++ b/src/main/java/com/demcha/compose/document/templates/cv/v2/theme/CvSpacing.java @@ -306,10 +306,11 @@ public static CvSpacing sidebarPortrait() { /** * Spacing for the Monogram Sidebar preset: zero page-flow gap so - * the pale sidebar fill bleeds edge-to-edge against the - * RECOMMENDED_MARGIN=0 page bounds. Banner tokens are unused — - * the preset draws its visual chrome inline (monogram badge, rules, - * filler shape). + * the content sits flush against the RECOMMENDED_MARGIN=0 page + * bounds. The pale sidebar fill is painted edge-to-edge on every + * page by {@code DocumentSession.pageBackgrounds(...)}, not by this + * spacing; banner tokens are unused — the preset only draws the + * monogram badge and sidebar heading rules inline. */ public static CvSpacing monogramSidebar() { return new CvSpacing( diff --git a/src/test/java/com/demcha/compose/document/templates/cv/v2/presets/PanelSmokeTest.java b/src/test/java/com/demcha/compose/document/templates/cv/v2/presets/PanelSmokeTest.java index 05410d14..8671577f 100644 --- a/src/test/java/com/demcha/compose/document/templates/cv/v2/presets/PanelSmokeTest.java +++ b/src/test/java/com/demcha/compose/document/templates/cv/v2/presets/PanelSmokeTest.java @@ -20,7 +20,10 @@ * Smoke test for the v2 Panel preset. Covers the header card with * optional job title + link row, plus the two-column row composition * fed through {@link com.demcha.compose.document.templates.cv.v2.components.SectionLookup} - * and {@link com.demcha.compose.document.templates.cv.v2.components.SectionDispatcher}. + * and the preset-local body dispatcher (Panel renders its own + * row-free dispatch because each card sits inside {@code flow.addRow}, + * which the engine forbids from containing nested rows — so it cannot + * delegate to the shared {@code SectionDispatcher}). */ class PanelSmokeTest {