feat(cv-v2): migrate Engineering Resume preset#64
Merged
Conversation
Ports the legacy Engineering Resume CV preset onto the v2 layered
architecture. The preset stays a thin orchestrator that uses theme
tokens for body ink / muted / rule / profile-band fill and keeps
the navy header, green accent and rail-text variants as preset-local
fifth+ tokens (same pattern as NordicClean / EditorialBlue).
Preset
* CvTheme.engineeringResume() factory wires CvPalette.engineeringResume()
(slate body ink, muted slate subtitles, pale teal-green rule, soft
green profile-band fill), CvTypography.engineeringResume() (Barlow
display + Lato body, 24.5/7.2/7.8/8.0/7.1/7.0/7.25, 1.08 line
spacing), and CvSpacing.engineeringResume() (8pt page-flow, 2.5pt
header accent rule, 4pt card corner).
* Navy command header (top-rounded card with green-accent bottom
strip): UPPERCASE Barlow name + subtitle line (uses
identity.jobTitle() with a deterministic 'SECURE BACKEND SYSTEMS /
DELIVERY LEADERSHIP' fallback) + right-aligned contact stack with
cyan-green underlined links.
* 2-column body (weights 0.76 / 1.64):
- Navy skill rail (bottom-rounded, accent-top strip): Core Stack
(skills key:value), Learning (education title / date), Details
(additional rows). Rail body uses preset-local RAIL_TEXT/RAIL_DATE.
- Main column: Profile card (pale green fill with green left
accent), Leadership Experience (white cards with green left
accent, role title / date header), Technical Evidence (compact
white project cards with green context strip via ProjectLabel).
* Preset-local body rendering avoids EntryRenderer's 2-column Row
(the engine bans nested horizontal rows and every body card sits
inside flow.addRow).
Also includes a tiny TimelineMinimal cleanup:
* StringBuilder.length() > 0 → !StringBuilder.isEmpty() (Java 15+
idiomatic). No behaviour change.
Tests
* CvV2VisualParityTest now exercises 13 presets (added engineering_resume);
13/13 pass at the existing 50k pixel-diff budget against the new
visual-baselines/cv-v2-layered/engineering_resume-page-0.png baseline.
* EngineeringResumeSmokeTest covers stable identity + default-factory
and custom-theme render paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the legacy Engineering Resume CV preset onto the v2 layered architecture.
Visual signature (preserved from V1)
identity.jobTitle()if present, otherwise the deterministic'SECURE BACKEND SYSTEMS / DELIVERY LEADERSHIP'fallback.key: value), Learning (educationtitle / date), Details (additional rows). Rail body uses preset-localRAIL_TEXT/RAIL_DATE.GREEN_SOFTfill with green left accent), Leadership Experience (white cards with green left accent, roletitle / dateheader), Technical Evidence (compact white project cards with green context strip viaProjectLabel).Theme additions — additive
CvPalette.engineeringResume()— slate body ink, muted slate, pale teal-green rule, soft green profile-band fill.CvTypography.engineeringResume()— Barlow + Lato, 24.5/7.2/7.8/8.0/7.1/7.0/7.25, 1.08 line spacing.CvSpacing.engineeringResume()— 8pt page-flow, 2.5pt header accent rule, 4pt card corner radius.CvTheme.engineeringResume()factory.Preset-local tokens
NAVY,NAVY_SOFT,GREEN,RAIL_TEXT,RAIL_DATE,SUBTITLE_COLOR,CONTACT_META,CONTACT_LINK— same fifth+ token pattern as NordicClean / EditorialBlue.Architecture
Preset-local body rendering avoids
EntryRenderer's 2-column Row (the engine bans nested horizontal rows and every body card sits insideflow.addRow). Entries are drawn as single-paragraphtitle / dateheaders.Drive-by cleanup
StringBuilder.length() > 0with!StringBuilder.isEmpty()inTimelineMinimal.sectionLines(...)(Java 15+ idiomatic). No behaviour change.Test plan
./mvnw test -Dtest=com.demcha.compose.document.templates.cv.v2.presets.EngineeringResumeSmokeTest -pl .— 3/3./mvnw test -Dtest=com.demcha.compose.document.templates.cv.v2.presets.CvV2VisualParityTest -Dgraphcompose.visual.approve=true -pl .— 13/13 first-time baseline approval./mvnw test -Dtest=com.demcha.compose.document.templates.cv.v2.presets.CvV2VisualParityTest -pl .— 13/13 without approveexamples/target/generated-pdfs/templates/cv/cv-engineering-resume-v2.pdf