feat(cv-v2): markdown cleanup, widget extraction, drop preset style wrapper#60
Merged
Merged
Conversation
…rapper * Route preset rich-text through MarkdownInline / RichParagraphRenderer instead of touching the engine MarkDownParser directly. Presets that used .rich(...) now share one adapter. * Extract shared body renderers (EntryCompactRenderer, ProjectRenderer, LabelValueRenderer, SkillLineRenderer, SkillTableRenderer) and shared widgets (FlowSectionHeader, Masthead, ProfileBand, SectionModule, CardWidget) so v2 presets stay thin orchestrators. * Drop the duplicated 'private static DocumentTextStyle style(...)' wrapper from BlueBanner, ClassicSerif, CompactMono, EditorialBlue, NordicClean. All call sites now use CvTextStyles.of(...) directly and the unused FontName imports are removed. * Inline single-use isEducation / isProjects helpers in EditorialBlue via SectionLookup, and replace inline DocumentTextStyle.builder() for the BlueBanner banner-title with CvTextStyles.of for consistency. All cv/v2 pixel baselines unchanged: CvV2VisualParityTest passes 9/9 without -Dgraphcompose.visual.approve, smoke tests 24/24, full suite 932/932.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarkdownInline/RichParagraphRenderer— no preset touches the engineMarkDownParserdirectly anymore.EntryCompactRenderer,ProjectRenderer,LabelValueRenderer,SkillLineRenderer,SkillTableRenderer) and shared widgets (FlowSectionHeader,Masthead,ProfileBand,SectionModule,CardWidget) so v2 presets stay thin orchestrators.private static DocumentTextStyle style(...)wrapper from 5 presets (BlueBanner,ClassicSerif,CompactMono,EditorialBlue,NordicClean). All call sites useCvTextStyles.of(...)directly; unusedFontNameimports are removed.isEducation/isProjectshelpers inEditorialBlueviaSectionLookup; replace inlineDocumentTextStyle.builder()inBlueBannerbanner title withCvTextStyles.offor consistency.Preset size impact (drop-style-wrapper pass)
Test plan
./mvnw test -Dtest=com.demcha.compose.document.templates.cv.v2.presets.CvV2VisualParityTest -pl .— 9/9 pixel baselines unchanged (no-Dgraphcompose.visual.approve)./mvnw test -Dtest='com.demcha.compose.document.templates.cv.v2.**' -pl .— 82/82 cv/v2 tests./mvnw test -pl .— 932/932 full canonical suite