fix(web): drop duplicate v1 CV showcase cards, keep v2 only#138
Merged
Conversation
The CV / Resume gallery showed every preset twice: the curated v2 card (e.g. cv-blue-banner-v2) plus a stale bare placeholder (cv-blue-banner) with a generic "Generated showcase for…" description and a 404 PDF link (the bare cv-*.pdf were never tracked/deployed). Root cause: stale CvTemplateGalleryFileExample output (bare cv-<id>.pdf, not wired into GenerateAllExamples) lingered in target/generated-pdfs and leaked into the committed manifest + screenshots via the non-pruning ShowcaseSync. Only the CV group was affected. - examples.json: remove the 16 bare CV entries, keep the 16 -v2 ones (site cards 70 -> 54) - showcase/screenshots/templates/cv: remove the 16 stale bare previews - sitemap.xml: repoint the CV hero URL to cv-modern-professional-v2.pdf (the bare URL 404'd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CV / Resume showcase gallery listed every preset twice: the curated
v2 card (e.g.
cv-blue-banner-v2) plus a stale bare placeholder(
cv-blue-banner) with a generic "Generated showcase for…" description.The bare cards' PDF links also 404'd — the bare
cv-*.pdfwere nevergit-tracked, so they were never deployed to Pages.
Root cause
ShowcaseSyncwalks everything underexamples/target/generated-pdfs/**and never prunes. Stale
CvTemplateGalleryFileExampleoutput (barecv-<id>.pdf, not wired intoGenerateAllExamples) lingered intarget/and leaked into the committed manifest + screenshots. Only the CV group
was affected —
uniq -dover the manifest confirms no other duplicates.Change
web/examples.json: remove the 16 bare CV entries, keep the 16-v2(site cards 70 → 54). Re-validated as JSON; all other bytes untouched.
web/showcase/screenshots/templates/cv/: remove the 16 stale bare PNGs.web/sitemap.xml: repoint the CV hero URL tocv-modern-professional-v2.pdf.Invoice (canonical) and Proposal (canonical) V1 cards are intentionally
kept — those are distinct templates, not duplicates.
Deploy
GitHub Pages serves the committed
web/verbatim (deploy-web.yml, no buildstep), so merging to
mainupdates the live site.