fix(benchmarks): add jasperreports-pdf for JR7 PDF export (hotfix to main)#136
Merged
Conversation
…iveBenchmark
JasperReports 7 modularised PDF export out of the core jasperreports jar into a separate jasperreports-pdf extension. ComparativeBenchmark#benchmarkJasper calls JasperExportManager.exportReportToPdf, which failed at runtime with "Missing JasperReports PDF Extension (jasperreports-pdf-x.x.x.jar)" because only the core artifact was on the classpath.
Add jasperreports-pdf at the same ${jasperreports.version} (7.0.7). The current-speed suite was unaffected; only the comparative step (03-comparative in run-benchmarks.ps1) was broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix -> main
Ports the JasperReports 7 PDF-export fix (already on
developvia #133) to the releasedmainline.ComparativeBenchmark#benchmarkJaspercallsJasperExportManager.exportReportToPdf, which fails at runtime withMissing JasperReports PDF Extension (jasperreports-pdf-x.x.x.jar). JasperReports 7 split PDF export out of the core jar into a separatejasperreports-pdfmodule that was not on the classpath, soscripts/run-benchmarks.ps1dies at step03-comparativeon main too. The current-speed suite is unaffected.Fix: add
net.sf.jasperreports:jasperreports-pdfat the same${jasperreports.version}(7.0.7). Benchmark-only — does not touch the publishedgraph-composejar.Verification
./mvnw -f benchmarks/pom.xml exec:java -Dexec.mainClass=com.demcha.compose.ComparativeBenchmarkon this branch -> BUILD SUCCESS; JasperReports renders (GraphCompose ~3.9 ms / iText ~2.7 ms / JasperReports ~6.5 ms).