Skip to content

Commit eb898df

Browse files
committed
Arm tuning
1 parent 3a53d73 commit eb898df

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/main/java/frc/robot/constants/ArmConstants.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,17 @@ public class ArmConstants {
5454
.withStatorCurrentLimitEnable(true)
5555
.withStatorCurrentLimit(60);
5656
public static final Slot0Configs SLOT_0_CONFIGS = new Slot0Configs()
57-
.withKP(22) // 22
57+
.withKP(8) // 22
5858
.withKI(0)
5959
.withKD(0)
6060
.withKS(0.081) // 0.081
61-
.withKV(8.15) // 8.15
61+
.withKV(7.8) // 8.15
6262
.withKA(0)
63-
.withKG(0.428) // 0.428
63+
.withKG(0.518) // 0.428
6464
.withGravityType(GravityTypeValue.Arm_Cosine);
6565
public static final MotionMagicConfigs MOTION_MAGIC_CONFIGS = new MotionMagicConfigs()
6666
.withMotionMagicCruiseVelocity(0.6) // 0.6
67-
.withMotionMagicAcceleration(2); // 2?
67+
.withMotionMagicAcceleration(0.9); // 2?
6868
public static final MotorOutputConfigs MOTOR_OUTPUT_CONFIGS = new MotorOutputConfigs()
6969
.withNeutralMode(NeutralModeValue.Brake)
7070
.withInverted(InvertedValue.Clockwise_Positive);

src/main/java/frc/robot/constants/SuperstructureConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ public class SuperstructureConstants {
204204

205205
// Error margins
206206
public static final double ELEVATOR_ERROR_MARGIN = 1;
207-
public static final double ARM_ERROR_MARGIN = 0.1;
207+
public static final double ARM_ERROR_MARGIN = 0.075;
208208
public static final double WRIST_ERROR_MARGIN = 0;
209209
public static final double CLAW_ERROR_MARGIN = 0;
210210

0 commit comments

Comments
 (0)