Endless loop in BracketNotationParser

[thuetter]

In case of an invalid input, the bracket notation parser may end up in an endless loop. More specifically, the while loop in function parse_single does not increase the iterator in case that match_str is no bracket.

Minimal example:
{a{b}c}
This causes an endless loop with match_str equal to c.

[remz1337]

Has this been resolved already? Can't seem to reproduce (tested on both my Windows and CentOS machines) using the provided minimal example

[mateuszpawlik]

Thanks @remz1337. @thuetter will check it next week.

[thuetter]

I just checked and it seems like there is a workaround for this bug which prevents the nested loop. In lines 89-93, invalid characters are skipped which guarantees termination. However, the expected behaviour might exit with an appropriate error message. Needs some engineering.

[mateuszpawlik]

Do you mean these lines?

tree-similarity/src/parser/bracket_notation_parser_impl.h

Lines 89 to 92 in 76e6262

	// Skip incorrect token.
	if (consumed_token == false) {
	++tokens_begin; // Advance tokens.
	}

[thuetter]

Exactly.