Update module gopkg.in/DataDog/dd-trace-go.v1 to v2#51205
Conversation
|
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: CI tests failed. Please fix the failing tests to continue. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62d596ca2f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // the v2 package. Note that this tracer does not have support for the | ||
| // remote config key controlling the SymDB upload. | ||
| gopkg.in/DataDog/dd-trace-go.v1 v1.73.1 | ||
| gopkg.in/DataDog/dd-trace-go.v2 v2.2.3 |
There was a problem hiding this comment.
Restore v1 module requirement for rc_tester_v1
rc_tester_v1 still imports gopkg.in/DataDog/dd-trace-go.v1/... and is explicitly meant to exercise tracer v1 behavior, but this change replaces the pinned v1.73.1 dependency with gopkg.in/DataDog/dd-trace-go.v2. That drops the explicit non-wrapper v1 pin and can cause module resolution to either fail in read-only module mode or resolve to a newer transitional v1.74.x wrapper, which invalidates the test program’s intended v1 semantics (including the remote-config behavior noted in the adjacent comments).
Useful? React with 👍 / 👎.
|
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 0a5bcc5 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.53 | [+1.52, +7.54] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.53 | [+1.52, +7.54] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.49 | [+0.44, +0.54] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.47 | [+0.26, +0.68] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.42 | [+0.35, +0.49] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.19 | [-0.05, +0.42] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.05 | [-0.15, +0.26] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.05 | [-0.00, +0.10] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.03 | [-0.13, +0.19] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.02 | [-0.19, +0.24] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.39, +0.41] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.13, +0.15] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.46, +0.45] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.54, +0.51] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.05 | [-0.24, +0.14] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.06 | [-1.07, +0.95] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -0.15 | [-0.25, -0.06] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.22 | [-0.27, -0.18] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -0.35 | [-0.51, -0.19] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.38 | [-0.44, -0.33] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -0.45 | [-0.55, -0.34] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.11 | [-1.36, -0.87] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 691 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 246.48MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 740 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.16GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 142.81MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 742.07KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 2 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 424.74MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.12MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 177.26MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 263.99MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 350.82 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 370.34MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.94GiB ≤ 1.04GiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
This PR contains the following updates:
v1.73.1→v2.2.3Release Notes
DataDog/dd-trace-go (gopkg.in/DataDog/dd-trace-go.v1)
v2.2.3Compare Source
What's Changed
This patch release fixes a significant bug that caused dropped spans due to local sampling rules overriding the sampling decision already present in inbound distributed trace context.
Application Performance Monitoring (APM)
Full Changelog: DataDog/dd-trace-go@v2.2.2...v2.2.3
v2.2.2Compare Source
What's Changed
Application Performance Monitoring (APM)
App & API Protection
Profiling
enabledfield to startup log by @mtoffl01 in #3712Ci Visibility
General
@latestto v2fix install command by @mkusaka in #3654New Contributors
Full Changelog: DataDog/dd-trace-go@v2.1.0...v2.2.0
v2.2.1Compare Source
v2.2.0Compare Source
v2.1.0Compare Source
Summary
Application Performance Monitoring (APM)
Client-Side Stats Computation
Client-Side Stats computation is now enabled by default. This feature allows the Go tracer to compute aggregated span statistics locally before sending them to the Datadog Agent, resulting in reduced network traffic and improved performance.
What this means: Instead of sending all raw span data to the Agent, the tracer now sends pre-computed statistics, reducing bandwidth usage while maintaining full observability.
To disable, if needed: Set the environment variable
DD_TRACE_STATS_COMPUTATION_ENABLED=falseor usetracer.WithStatsComputation(false)when starting the tracer programmatically.File-based Configurations
Introduced support for configuring SDK products via a file on the underlying Linux system. #3438 Documentation
Baggage improvements
Fixed a distributed tracing bug in the baggage propagator. Also refactored baggage injection and extraction logic for improved performance and readability. #3439 #3597
Application Security Management (ASM)
contrib envoyproxy/go-control-plane:
What's Changed
Application Performance Monitoring (APM)
Application Security Management (ASM)
Profiling
CI Visibility
General
otelhttpversion by @darccio in #3551New Contributors
Full Changelog: DataDog/dd-trace-go@v2.0.0...v2.1.0
v2.0.1Compare Source
Summary
What's Changed
General
56a952bFull Changelog: DataDog/dd-trace-go@v2.0.0...v2.0.1
v2.0.0Compare Source
Summary
Datadog has long supported the monitoring of instrumented Go applications through our Go tracer v1. As the Go ecosystem has continued to mature, we’ve been hard at work collecting feedback and improving upon the tracer’s capabilities and usability features.
We are now thrilled to announce the release of dd-trace-go v2.0.0. This major update includes better security and stability, and a new and simplified API. In creating this updated version, we have incorporated valuable feedback both from our customer community and from our own teams at Datadog who use the Go tracer extensively. We have already tested this new version in production and have migrated all our internal services.
A migration guide has been provided to help users running version
1.xwith upgrading. It can be found here.To view the complete set of changes implemented in this release, please refer to the issues and PRs marked with the v2.0 label in our GitHub repository.
Further reading
v1.74.8Compare Source
v1.74.7Compare Source
This transitional version is the only v1 version that allows both v1 and v2 to be imported in the same service—enabling you to migrate a service gradually. Using this v1 transitional version doesn’t require any code changes, but it also won’t support any new features introduced in the new v2 tracer.
Changes
Updates
github.com/DataDog/dd-trace-go/v2fromv2.2.3tov2.3.0Full Changelog: DataDog/dd-trace-go@v1.74.6...v1.74.7
v1.74.6Compare Source
What's Changed
This patch release fixes a significant bug that caused dropped spans due to local sampling rules overriding the sampling decision already present in inbound distributed trace context.
Application Performance Monitoring (APM)
Full Changelog: DataDog/dd-trace-go@v1.74.5...v1.74.6
v1.74.5Compare Source
This transitional version is the only v1 version that allows both v1 and v2 to be imported in the same service—enabling you to migrate a service gradually. Using this v1 transitional version doesn’t require any code changes, but it also won’t support any new features introduced in the new v2 tracer.
Changes
Updates
github.com/DataDog/dd-trace-go/v2fromv2.1.0tov2.2.2Full Changelog: DataDog/dd-trace-go@v1.74.3...v1.74.5
v1.74.4Compare Source
This transitional version is the only v1 version that allows both v1 and v2 to be imported in the same service—enabling you to migrate a service gradually. Using this v1 transitional version doesn’t require any code changes, but it also won’t support any new features introduced in the new v2 tracer.
Changes
Updates
github.com/DataDog/dd-trace-go/v2fromv2.1.0tov2.2.2Full Changelog: DataDog/dd-trace-go@v1.74.3...v1.74.4
v1.74.3Compare Source
This transitional version is the only v1 version that allows both v1 and v2 to be imported in the same service—enabling you to migrate a service gradually. Using this v1 transitional version doesn’t require any code changes, but it also won’t support any new features introduced in the new v2 tracer.
Changes
Updates
github.com/DataDog/dd-trace-go/v2fromv2.0.1tov2.1.0Full Changelog: DataDog/dd-trace-go@v1.74.2...v1.74.3
v1.74.2: : v1 transitional versionCompare Source
This transitional version is the only v1 version that allows both v1 and v2 to be imported in the same service—enabling you to migrate a service gradually. Using this v1 transitional version doesn’t require any code changes, but it also won’t support any new features introduced in the new v2 tracer.
Changes
Removes dependencies updates from
go.modfiles mistakenly added when releasingv1.74.1Full Changelog: DataDog/dd-trace-go@v1.74.0...v1.74.2
v1.74.1: : v1 transitional versionCompare Source
This transitional version is the only v1 version that allows both v1 and v2 to be imported in the same service—enabling you to migrate a service gradually. Using this v1 transitional version doesn’t require any code changes, but it also won’t support any new features introduced in the new v2 tracer.
Changes
Updates
github.com/DataDog/dd-trace-go/v2fromv2.0.0tov2.0.1Full Changelog: DataDog/dd-trace-go@v1.74.0...v1.74.1
v1.74.0: : v1 transitional versionCompare Source
This transitional version is the only v1 version that allows both v1 and v2 to be imported in the same service—enabling you to migrate a service gradually. Using this v1 transitional version doesn’t require any code changes, but it also won’t support any new features introduced in the new v2 tracer.
Note that, while we are offering the v1 transitional version for the convenience of our customers, we strongly encourage you to upgrade to the v2 version as soon as possible to benefit from the newest features and improvements. If you have concerns or reasons to not upgrade to the transitional version, contact us and we’ll work together to resolve them.
v1.73.2Compare Source
What's Changed
Application Performance Monitoring (APM)
Full Changelog: DataDog/dd-trace-go@v1.73.1...v1.73.2
Configuration
📅 Schedule: (UTC)
* 0-4,22-23 * * 1-5)* * * * 0,6)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.