refactor: enhance verilator command options and update log file naming convention

Author: shirohasuki

api/steps/verilator/02_verilog_event_step.py

@@ -53,8 +53,18 @@ async def handler(data, context):
     else:
         command = f"mill -i __.test.runMain sims.verilator.Elaborate {config_name} "
 
-    command += "--disable-annotation-unknown -strip-debug-info -O=debug "
-    command += f"--split-verilog -o={build_dir}"
+    # Firtool options (CIRCT). Current set; optional Chipyard-style options below.
+    command += "--disable-annotation-unknown "
+    command += "--strip-debug-info "
+    command += "-O=debug "
+    # command += f"-repl-seq-mem -repl-seq-mem-file={build_dir}/mem.conf "
+    command += f"--split-verilog -o={build_dir} "
+    # Optional: --disable-annotation-classless (ignore classless annotations)
+    # Optional: -repl-seq-mem -repl-seq-mem-file=<path>.conf (SRAM macro replacement)
+    # Optional: --disable-all-randomization (disable mem/reg init; may break semantics)
+    # Optional: --disable-opt (no optimization) or -O=release (default is release)
+    # Optional: --output-annotation-file=<path> (emit annotations after lower-to-hw)
+    # Optional: --no-dedup (disable module dedup); --strip-fir-debug-info (FIR locators)
 
     result = stream_run_logger(
         cmd=command,

api/steps/verilator/03_build_event_step.py

@@ -74,6 +74,7 @@ def pkg_config(flag, pkg):
     ])
 
     # -DBBSIM: selects VBBSimHarness in bdb.h / main.cc
+    # BDB NDJSON trace (+trace=...) is runtime-only; bbdev sim uses +trace=all (04_sim_event_step.py).
     cflags = f"{inc_flags} -DBBSIM -DTOP_NAME='\"V{topname}\"' -std=c++17"
 
     ldflags = (
@@ -84,7 +85,7 @@ def pkg_config(flag, pkg):
     )
 
     obj_dir = f"{build_dir}/obj_dir"
-    subprocess.run(f"rm -rf {obj_dir}", shell=True)
+    # subprocess.run(f"rm -rf {obj_dir}", shell=True)
     os.makedirs(obj_dir, exist_ok=True)
 
     sources = " ".join(vsrcs + csrcs)

api/steps/verilator/04_sim_event_step.py

@@ -63,7 +63,7 @@ async def handler(data, context):
     bin_path = f"{build_dir}/obj_dir/V{topname}"
     batch = data.get("batch", False)
 
-    log_path    = f"{log_dir}/bdb.log"
+    log_path    = f"{log_dir}/bdb.ndjson"
     stdout_path = f"{log_dir}/stdout.log"
     fst_path    = f"{waveform_dir}/waveform.fst"
 
@@ -82,7 +82,7 @@ async def handler(data, context):
         f"+elf={binary_path} "
         f"{'+batch ' if batch else ''}"
         f"{coverage_flag + ' ' if coverage_flag else ''}"
-        f"+fst={fst_path} +log={log_path} +stdout={stdout_path} +permissive-off "
+        f"+fst={fst_path} +log={log_path} +stdout={stdout_path} +trace=all +permissive-off "
         f"{binary_path} 2> >(spike-dasm > {log_dir}/disasm.log)"
     )
     script_dir = os.path.dirname(__file__)