fix: NXDomain should continue to next server if available

radu-solomon-dnsf · radu-solomon-dnsf · commit 67c83e1e4e4d · 2025-06-13T13:26:06.000-04:00
diff --git a/ARSoft.Tools.Net/ARSoft.Tools.Net.csproj b/ARSoft.Tools.Net/ARSoft.Tools.Net.csproj
@@ -16,7 +16,7 @@
 		<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
 		<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
 		<Copyright>Copyright 2010..2024 Alexander Reinert</Copyright>
-		<VersionPrefix>3.6.1</VersionPrefix>
+		<VersionPrefix>3.6.2</VersionPrefix>
 		<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
 		<Platforms>AnyCPU;x64;ARM64</Platforms>
 	</PropertyGroup>
diff --git a/ARSoft.Tools.Net/Dns/DnsClientBase.cs b/ARSoft.Tools.Net/Dns/DnsClientBase.cs
@@ -157,7 +157,7 @@ private DnsRawPackage PrepareMessage<TMessage>(TMessage message, out SelectTsigK
                     {
                         connection.RestartIdleTimeout(receivedMessage.Message.GetEDnsKeepAliveTimeout());
 
-                        if (receivedMessage.Message.ReturnCode == ReturnCode.ServerFailure)
+                        if (receivedMessage.Message.ReturnCode is ReturnCode.ServerFailure or ReturnCode.NxDomain)
                         {
                             response = receivedMessage.Message;
                             continue;

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ private DnsRawPackage PrepareMessage<TMessage>(TMessage message, out SelectTsigK`
`157`	`157`	`{`
`158`	`158`	`connection.RestartIdleTimeout(receivedMessage.Message.GetEDnsKeepAliveTimeout());`
`159`	`159`
`160`		`- if (receivedMessage.Message.ReturnCode == ReturnCode.ServerFailure)`
	`160`	`+ if (receivedMessage.Message.ReturnCode is ReturnCode.ServerFailure or ReturnCode.NxDomain)`
`161`	`161`	`{`
`162`	`162`	`response = receivedMessage.Message;`
`163`	`163`	`continue;`