repos: segments and validate_test updates

Author: zer0stars

internal/repositories/segments.go

@@ -34,9 +34,7 @@ func validateSegmentArgs(tokenID int, from, to time.Time) error {
 		return fmt.Errorf("from and to times cannot be equal")
 	}
 
-	if to.After(time.Now()) {
-		return fmt.Errorf("to time cannot be in the future")
-	}
+	// to in future is handled by caller (GetSegments caps to now before calling)
 
 	maxDuration := maxDateRangeDays * 24 * time.Hour
 	if to.Sub(from) > maxDuration {
@@ -190,7 +188,11 @@ func sortSegmentSignals(signals []*model.SignalAggregationValue) {
 // GetSegments returns segments detected using the specified mechanism in the time range.
 // Pagination: pass after (exclusive cursor = startTime of last segment from previous page) and limit (default 100, max 200).
 // Segments are ordered by startTime ascending. When after is set, only segments with startTime > after are requested from CH.
+// If to is in the future (e.g. client sent end-of-day in user TZ), it is capped to now so the query succeeds.
 func (r *Repository) GetSegments(ctx context.Context, tokenID int, from, to time.Time, mechanism model.DetectionMechanism, config *model.SegmentConfig, signalRequests []*model.SegmentSignalRequest, eventRequests []*model.SegmentEventRequest, limit *int, after *time.Time) ([]*model.Segment, error) {
+	if now := time.Now(); to.After(now) {
+		to = now
+	}
 	if err := validateSegmentArgs(tokenID, from, to); err != nil {
 		return nil, errorhandler.NewBadRequestError(ctx, err)
 	}

internal/repositories/validate_test.go

@@ -79,11 +79,6 @@ func TestValidateSegmentArgs(t *testing.T) {
 		require.Error(t, err)
 	})
 
-	t.Run("to in future", func(t *testing.T) {
-		err := validateSegmentArgs(1, validFrom, time.Now().Add(time.Hour))
-		require.ErrorContains(t, err, "to time cannot be in the future")
-	})
-
 	t.Run("date range exceeded", func(t *testing.T) {
 		from := validTo.Add(-32 * 24 * time.Hour) // max is 31 days
 		err := validateSegmentArgs(1, from, validTo)