Skip to content

Commit d7828a0

Browse files
authored
Merge pull request #326 from DCMLab/fix_browser_observer_error
Fix browser observer error
2 parents 3736996 + 613a9c0 commit d7828a0

2 files changed

Lines changed: 0 additions & 37 deletions

File tree

src/js/modules/UI/Layers/index.js

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ class LayersMenu {
6464

6565
this.setDataPosition()
6666
this.addMouseListeners()
67-
this.observe()
68-
this.updateNavigation()
6967
this.updateLayersCount()
7068

7169
this.reductions.onTap(e)
@@ -131,36 +129,6 @@ class LayersMenu {
131129
doc.classList.toggle('not-in-layer-1', !layerOneIsActive)
132130
}
133131

134-
// Observe intersection of layers with viewport to know the current one.
135-
136-
observe() {
137-
138-
// Remove IntersectionObserver if there’s only 1 layer.
139-
if (this.contexts.length < 2) {
140-
this.contexts[0].observing = false
141-
142-
// https://w3c.github.io/IntersectionObserver/#lifetime
143-
return this.observer.disconnect()
144-
}
145-
146-
this.contexts
147-
.filter(layer => !layer.observing)
148-
.forEach(layer => {
149-
150-
/**
151-
* Add element that will always intersect respecting ratios.
152-
* See `/src/sass/score/score.scss`
153-
*/
154-
if (layer.layer.layer_elem.childElementCount == 1) {
155-
layer.layer.layer_elem.insertAdjacentHTML('beforeend',
156-
`<div class="layer-intersection-landmark" data-position="${layer.layer.layer_number}"></div>`
157-
)
158-
}
159-
this.observer.observe(layer.layer.layer_elem.querySelector('.layer-intersection-landmark'))
160-
layer.observing = true
161-
})
162-
}
163-
164132
addMouseListeners() {
165133
if (!navigation_conf.switch_context_on_hover) { return }
166134

src/js/modules/UI/Layers/layer_resize.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,6 @@ export function initLayerResize(layersMenu) {
117117
if (newHeight <= state.minHeight) {
118118
state.currentLayer.style.height = `${state.minHeight}px`
119119
}
120-
121-
// Update any related components if needed
122-
if (layersMenu && typeof layersMenu.observe === 'function') {
123-
layersMenu.observe()
124-
}
125120
}
126121

127122
/**

0 commit comments

Comments
 (0)