Skip to content
This repository was archived by the owner on Jul 14, 2020. It is now read-only.

Commit ecda4e4

Browse files
authored
General perf improvements for CBT.NuGet (#287)
* Exclude traversal projects from generated solution file * Only write assets flag file if CBTNuGetGeneratePackageProperties is true
1 parent 65f9a9a commit ecda4e4

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/CBT.NuGet/Tasks/TraversalNuGetRestore.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ private bool TryWriteSolutionFile(ProjectCollection projectCollection)
162162
{
163163
writer.WriteLine("Microsoft Visual Studio Solution File, Format Version 12.00");
164164

165-
foreach (var project in projectCollection.LoadedProjects)
165+
foreach (var project in projectCollection.LoadedProjects.Where(i => !String.Equals(i.GetPropertyValue("IsTraversal"), "true", StringComparison.OrdinalIgnoreCase)))
166166
{
167167
Uri toUri = new Uri(project.FullPath, UriKind.Absolute);
168168

src/CBT.NuGet/build/After.Microsoft.Common.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<Import Project="$(CBTBuildPackageTargetsFile)" Condition=" '$(CBTEnableImportBuildPackages)' != 'false' And Exists('$(CBTBuildPackageTargetsFile)') "/>
1414

1515
<Target Name="GenerateNuGetAssetFlagFileInsideVisualStudio"
16-
Condition=" '$(BuildingInsideVisualStudio)' == 'true' "
16+
Condition=" '$(BuildingInsideVisualStudio)' == 'true' And '$(CBTNuGetGeneratePackageProperties)' == 'true'"
1717
Inputs="$(CBTNuGetRestoreFile)"
1818
Outputs="$(CBTNuGetAssetsFlagFile)">
1919

src/CBT.NuGet/build/CBT.NuGet.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@
181181
</Target>
182182

183183
<!-- _GenerateRestoreProjectSpec is a from the NuGet.targets new to NuGet 4.x. This target must be in the props chaining in by the cbt\obj\modules\build.props and not in the after.microsoft.common.targets extension as the Microsoft common targets are not pulled in during the NuGet evaluation of the project. -->
184-
<Target Name="GenerateNuGetAssetFlagFile" AfterTargets="_GenerateRestoreProjectSpec" >
184+
<Target Name="GenerateNuGetAssetFlagFile" AfterTargets="_GenerateRestoreProjectSpec" Condition=" '$(CBTNuGetGeneratePackageProperties)' == 'true' ">
185185
<ItemGroup>
186186
<RestoreAssetsFlagData Remove="@(RestoreAssetsFlagData)"/>
187187
<RestoreAssetsFlagData Include="ProjectJsonPath">

0 commit comments

Comments
 (0)