New selection box selects nodes that aren't in the selection box

[CoreyCorza]

Seems to be more vertically related than horizontally related for some reason. As if to suggest node bounding boxes are larger vertically than they should be? Im not sure.

brave_M8b9mKtfEK.mp4

ComfyUI Frontend Version

1.36.2

Browser

Chrome/Chromium

┆Issue is synchronized with this Notion page by Unito

[dosubot]

The selection box is picking up nodes outside its visible bounds—especially vertically—because the selection logic uses each node's bounding box, which is calculated to include extra vertical space like the title bar and padding. This means the node's "hitbox" for selection is often taller than what you see on screen, so nodes can get selected even if only a small part of their bounding box overlaps the selection rectangle. This is a known quirk in the way ComfyUI calculates node areas for selection, and it's especially noticeable after recent updates that switched the selection rectangle to a DOM overlay and added live selection logic [source].

The crash is likely related to Chrome/Chromium running out of memory when rendering large or complex node layouts, especially in Vue mode, which uses more DOM elements and padding [source]. You can sometimes work around this by reducing the number of nodes, switching to LiteGraph mode, or using a different browser like Firefox.

If you want to experiment with a local fix, you could look into adjusting how node bounding boxes are calculated in LGraphNode.measure() and updateArea() to better match the visible node area, but be aware this could affect other interactions like dragging and linking.

Let me know if you want more details on the code or possible workarounds!

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}