Deprecate components#475
Merged
Merged
Conversation
alien1976
approved these changes
May 15, 2026
There was a problem hiding this comment.
Pull request overview
Marks the legacy GameUIComponents suite as deprecated in favor of the new Gameface UI framework. Adds a styled "Package Deprecated" banner to the root and CLI READMEs, bumps patch versions across the library/CLI/root, removes the entire interaction-manager/ package, and teaches scripts/publish.js to skip already-deprecated packages and to call npm deprecate after each successful publish.
Changes:
- Add HTML deprecation banners pointing users to
gameface-ui.coherent-labs.comin the root andtools/cliREADMEs. - Bump patch versions (
package.json,lib/package.json,tools/cli/package.json). - Remove the
interaction-manager/package and its publish entry; add automaticnpm deprecateafter publish inscripts/publish.js.
Reviewed changes
Copilot reviewed 107 out of 112 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds deprecation banner div directing users to new Gameface UI. |
| tools/cli/README.md | Same deprecation banner for the CLI package. |
| package.json | Root version bump 1.0.0 → 1.0.1. |
| lib/package.json | Library version bump 3.3.0 → 3.3.1. |
| tools/cli/package.json | CLI version bump 4.0.2 → 4.0.3. |
| scripts/publish.js | Skips packages already deprecated on npm and calls npm deprecate after each publish; removes interaction-manager publish entry. |
| interaction-manager/src/** (deleted) | Entire interaction-manager package source removed (zoom, rotate, resize, touch-gestures, spatial-navigation, utils, etc.). |
Files not reviewed (1)
- components/router/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * @param {string} folder | ||
| */ | ||
| async function publish(component, folder = COMPONENTS_PATH) { | ||
| if (execSync(`npm view ${component} deprecated`, { encoding: 'utf8' })) return console.warn(`Package ${component} is deprecated. Won't publish!`); |
|
|
||
| await createRelease(tag); | ||
| execSync(`npm publish`, { cwd: path.join(folder, component), encoding: 'utf8', stdio: 'inherit' }); | ||
| execSync(`npm deprecate ${name} "This package is deprecated and no longer maintained. Please migrate to the new Gameface UI at https://gameface-ui.coherent-labs.com/"`, { encoding: 'utf8', stdio: 'inherit' }); |
Comment on lines
132
to
135
| try { | ||
| if (shouldUpdate('lib', LIBRARY_PATH)) await publish('lib', LIBRARY_PATH); | ||
| if (shouldUpdate('cli', CLI_PATH)) await publish('cli', CLI_PATH); | ||
| if (shouldUpdate('interaction-manager', LIBRARY_PATH)) await publish('interaction-manager', LIBRARY_PATH); | ||
|
|
Comment on lines
+6
to
+12
| <div style="background-color: rgba(255, 229, 100, 0.3); border-left: 5px solid #e5c100; padding: 15px; margin-bottom: 20px; border-radius: 4px;"> | ||
| <h3 style="margin-top: 0">⚠️ Package Deprecated</h3> | ||
| <p style=" margin-bottom: 0;"> | ||
| This legacy package has been deprecated in favor of the updated Gameface UI suite. | ||
| Please switch to the official framework at <a href="https://gameface-ui.coherent-labs.com/" style=" font-weight: bold; text-decoration: underline;">Gameface UI</a>. | ||
| </p> | ||
| </div> |
MartinBozhilov-coh
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove any item from the list if not applicable by editing this message.