improvement(sct/service): Locate coredumps in new events system

This commit splits the coredump finding logic into the legacy text event
function and a coredump link creator, which is now also used inside the
new event system, checking each event if it's a coredump and then trying
to create a link for it.

Fixes ARGUS-102

Author: k0machi

argus/backend/plugins/sct/service.py

@@ -5,9 +5,11 @@
 import math
 import re
 from time import time
+from typing import TypedDict
 from uuid import UUID
 from xml.etree import ElementTree
 from flask import current_app, g
+from cassandra.util import uuid_from_time
 from argus.backend.db import ScyllaCluster
 from argus.backend.models.github_issue import GithubIssue, IssueLink
 from argus.backend.models.web import ArgusEventTypes, ErrorEventEmbeddings, CriticalEventEmbeddings
@@ -78,6 +80,10 @@ class EventSubmitRequest:
     nemesis_status: str | None = None
 
 
+class CoredumpLink(TypedDict):
+    log_name: str
+    log_link: str
+
 
 class SCTService:
 
@@ -413,8 +419,8 @@ def finalize_nemesis(run_id: str, nemesis_details: dict) -> str:
         return "updated"
 
 
-    @staticmethod
-    def submit_event(run_id: str, raw_event: RawEventPayload):
+    @classmethod
+    def submit_event(cls, run_id: str, raw_event: RawEventPayload):
         req = EventSubmitRequest(**raw_event)
 
         event = SCTEvent()
@@ -438,7 +444,13 @@ def submit_event(run_id: str, raw_event: RawEventPayload):
         event.known_issue = req.known_issue
 
         event.save()
-
+        try:
+            if event.event_type.lower() == "coredumpevent" and (link := cls.create_coredump_link(event.message, event.ts)):
+                run: SCTTestRun = SCTTestRun.get(id=event.run_id)
+                run.submit_logs([link])
+                run.save()
+        except Exception:
+            LOGGER.warning("Unable to parse event for coredump links.", exc_info=True)
         # Add to unprocessed events queue for ERROR and CRITICAL events
         if event.severity in (SCTEventSeverity.ERROR.value, SCTEventSeverity.CRITICAL.value):
             try:
@@ -490,41 +502,56 @@ def submit_events(run_id: str, events: list[dict]) -> str:
 
         return "added"
 
-    @staticmethod
-    def locate_coredumps(run: SCTTestRun, events: list[EventsBySeverity]) -> list[dict]:
+    @classmethod
+    def locate_coredumps(cls, run: SCTTestRun, events: list[EventsBySeverity]) -> list[CoredumpLink]:
         flat_messages: list[str] = []
         links = []
         for es in events:
             flat_messages.extend(es.last_events)
         coredump_events = filter(lambda v: "coredumpevent" in v.lower(), flat_messages)
-        for idx, event in enumerate(coredump_events):
-            core_pattern = r"corefile_url=(?P<url>.+)$"
-            ts_pattern = r"^(?P<ts>\d{4}-\d{2}-\d{2} ([\d:]*)\.\d{3})"
-            node_name_pattern = r"node=(?P<name>.+)$"
-            core_url_match = re.search(core_pattern, event, re.MULTILINE)
-            node_name_match = re.search(node_name_pattern, event, re.MULTILINE)
-            ts_match = re.search(ts_pattern, event)
-            if core_url_match:
-                node_name = node_name_match.group("name") if node_name_match else f"unknown-node-{idx}"
-                split_name = node_name.split(" ")
-                node_name = split_name[1] if len(split_name) >= 2 else node_name
-                url = core_url_match.group("url")
-                ext = url.rsplit(".", maxsplit=1)[-1]
-                ext = ext if len(ext) <= 5 else "zst" # Default to .zst if URL doesn't conform
-                timestamp_component = ""
-                if ts_match:
-                    try:
-                        timestamp = datetime.fromisoformat(ts_match.group("ts"))
-                        timestamp_component = timestamp.strftime("-%Y-%m-%d_%H-%M-%S")
-                    except ValueError:
-                        pass
-                log_link = {
-                    "log_name": f"core.scylla-{node_name}{timestamp_component}.{ext}",
-                    "log_link": url
-                }
-                links.append(log_link)
+        for event in coredump_events:
+            if link := cls.create_coredump_link(event):
+                links.append(link)
         return links
 
+    @staticmethod
+    def create_coredump_link(event_message: str, event_ts: datetime | None = None) -> CoredumpLink | None:
+        core_pattern = r"corefile_url=(?P<url>.+)$"
+        ts_pattern = r"^(?P<ts>\d{4}-\d{2}-\d{2} ([\d:]*)\.\d{3})"
+        node_name_pattern = r"node=(?P<name>.+)$"
+        core_url_match = re.search(core_pattern, event_message, re.MULTILINE)
+        node_name_match = re.search(node_name_pattern, event_message, re.MULTILINE)
+        ts_match = re.search(ts_pattern, event_message)
+        timestamp = datetime.now(UTC)
+        if core_url_match:
+            url = core_url_match.group("url")
+            ext = url.rsplit(".", maxsplit=1)[-1]
+            ext = ext if len(ext) <= 5 else "zst" # Default to .zst if URL doesn't conform
+            timestamp_component = ""
+            if event_ts:
+                timestamp_component = event_ts.strftime("-%Y-%m-%d_%H-%M-%S")
+            elif ts_match:
+                try:
+                    timestamp = datetime.fromisoformat(ts_match.group("ts"))
+                    timestamp_component = timestamp.strftime("-%Y-%m-%d_%H-%M-%S")
+                except ValueError:
+                    pass
+            else:
+                timestamp_component = timestamp.strftime("-%Y-%m-%d_%H-%M-%S")
+            node_name = (
+                node_name_match.group("name")
+                if node_name_match
+                else f"unknown-node-{uuid_from_time(event_ts or timestamp, node=1000, clock_seq=128)}"
+            )
+            split_name = node_name.split(" ")
+            node_name = split_name[1] if len(split_name) >= 2 else node_name
+            log_link = {
+                "log_name": f"core.scylla-{node_name}{timestamp_component}.{ext}",
+                "log_link": url
+            }
+            return log_link
+        return None
+
     @staticmethod
     def get_similar_events(run_id: str) -> list[dict]:
         """Get similar events for each event in a test run