Skip to content

issues with test_solve_regression #590

@bouweandela

Description

@bouweandela

The test packages/climate-ref-esmvaltool/tests/unit/test_solve_regression.py::test_solve_regression seems to pick up the default default_ignore_datasets.yml file instead of the one from the git repository it is run from. For example, the default ignore datasets file was updated in #585 without updating the regression outputs, and the tests were all green on that pull request. On a subsequent pull request they fail: https://github.com/Climate-REF/climate-ref/actions/runs/22848594747/job/66271138543?pr=589.

The test is also parametrized in a way that is somewhat confusing and may be needlessly slow. It solves all diagnostics at once and is parametrized only over comparing the results of the solve per diagnostic, instead of solving just the for the requested diagnostic. For example, when running pytest packages/climate-ref-esmvaltool/tests/unit/test_solve_regression.py::test_solve_regression[sea-ice-sensitivity], it will not just solve the sea-ice-sensitivity diagnostic, but also all of the other ones. That is confusing if the solve fails on a diagnostic that is not sea-ice-sensitivity.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions