Skip to content
This repository was archived by the owner on Apr 17, 2020. It is now read-only.
This repository was archived by the owner on Apr 17, 2020. It is now read-only.

Potential memory leak #22

@kennethlarsen

Description

@kennethlarsen

When running the test suite in our app I see that the app doesn't tear down as expected. When investigating I saw that this was caused by ember-makeup. I haven't had time yet to do a proper investigation but Chrome points to the constructor here as the issue:

  // @TODO: This fails, when the primary host does not depend on `ember-makeup`
  // directly. What should the correct behavior be? I think we should throw a
  // build error, similar to `ember-cli-resolve-asset`.
  class MakeupService extends Ember.Service.extend(Ember.Evented) {
    constructor(...args) {
      super(...args);
      this.classNamePrefix = _config.default.options.contextClassNamePrefix;
      this.themePaths = _config.default.themePaths;
      this.linkElement = void 0;
      this.computedStyle = void 0;
      this.isReady = false;
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions