From 3e6f185e8abaa7ab47122875a5a23d632eeb6538 Mon Sep 17 00:00:00 2001 From: MathieuPoux Date: Tue, 14 Apr 2026 18:30:43 +0200 Subject: [PATCH 1/4] fix(PlayerStats)!: rename waitingData to buffering for clarity in player stats --- src/stats/PlayerStats.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/stats/PlayerStats.ts b/src/stats/PlayerStats.ts index ce0fb4a..2eedbe0 100644 --- a/src/stats/PlayerStats.ts +++ b/src/stats/PlayerStats.ts @@ -16,7 +16,7 @@ import { Loggable } from '../Log'; export class PlayerStats extends Loggable { protocol?: string; // protocol: HLS, DASH, WRTS, HESP, SMOOTH currentTime?: number; // current time in ms - waitingData?: boolean; + buffering?: boolean; // true on startup or when rebuffering after a stall bufferAmount?: number; // buffer amount in ms latency?: number; // latency in ms @@ -104,8 +104,8 @@ export class PlayerStats extends Loggable { if (proto != null) { cmcd.sf = (sfByProtocol[proto as keyof typeof sfByProtocol] ?? 'o') as CML.CmcdStreamingFormat; // Streaming Format } - if (this.waitingData != null) { - cmcd.su = this.waitingData; // Startup + if (this.buffering != null) { + cmcd.su = this.buffering; // Startup } return cmcd; } From 397f858bb7e79411cc916e1e855daa34dace57ff Mon Sep 17 00:00:00 2001 From: MathieuPoux Date: Tue, 14 Apr 2026 18:35:52 +0200 Subject: [PATCH 2/4] fix(PlayerStats): repair PlayerStats.spec.ts with the new waitingData->buffering renaming --- src/stats/PlayerStats.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stats/PlayerStats.spec.ts b/src/stats/PlayerStats.spec.ts index 17bf8a4..6299dae 100644 --- a/src/stats/PlayerStats.spec.ts +++ b/src/stats/PlayerStats.spec.ts @@ -17,7 +17,7 @@ describe('PlayerStats', () => { stats.playbackRate = 1.5; stats.audioByteRate = 60; stats.videoByteRate = 1500; - stats.waitingData = true; + stats.buffering = true; stats.stallCount = 3; stats.videoTrackId = 1; stats.videoTrackBandwidth = 1500; From e200fe960c1a3f8fd32cc4d16bd2cf47b6ce8a39 Mon Sep 17 00:00:00 2001 From: MathieuPoux Date: Tue, 14 Apr 2026 20:58:34 +0200 Subject: [PATCH 3/4] chore(deploy-docs): refine workflow conditions and remove unnecessary cache setting --- .github/workflows/deploy-docs.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/deploy-docs.yml index 588c005..a38e834 100644 --- a/.github/workflows/deploy-docs.yml +++ b/.github/workflows/deploy-docs.yml @@ -5,7 +5,6 @@ on: types: [completed] branches: [main] workflow_dispatch: - branches: [main] permissions: contents: read @@ -14,7 +13,7 @@ jobs: build-and-deploy: name: build and deploy docs runs-on: ubuntu-latest - if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }} + if: ${{ (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') || (github.event_name == 'workflow_dispatch' && github.ref == 'refs/heads/main') }} permissions: contents: write steps: @@ -24,7 +23,6 @@ jobs: - name: Setup Node.js uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1 with: - cache: npm node-version: lts/* - name: Install dependencies From 0525378a2f153058da9de1828524d09e91092698 Mon Sep 17 00:00:00 2001 From: MathieuPoux Date: Tue, 14 Apr 2026 20:59:29 +0200 Subject: [PATCH 4/4] chore(package): update test command and refine pre-push hook to check error --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index a54d67d..e415f29 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "build": "rollup -c", "build:es5": "rollup -c --format umd", "build:docs": "typedoc index.ts", - "test": "vitest", + "test": "vitest --run", "test:coverage": "vitest --run --coverage", "lint": "eslint . && prettier --check .", "eslint": "eslint --fix .", @@ -32,8 +32,8 @@ }, "simple-git-hooks": { "pre-commit": "npx lint-staged", - "pre-push": "npm run build", - "prepare-commit-msg": "npx --no -- commitlint --edit $1" + "pre-push": "npm run build && npm run test && npm run build:docs", + "commit-msg": "npx --no -- commitlint --edit $1" }, "author": "Ceeblue B.V.", "license": "AGPL-3.0-or-later",