Skip to content

Floating point representations of valid integer geometry flags crash ck2yaml #1395

@corykinney

Description

@corykinney

Problem description

c2yaml crashes when the transport geometry flag is a float representation of a valid integer flag (e.g. 0.000, 1.000, 2.000).

Expected Behavior

This has been discussed previously in #446, but rather than reviving that issue I decided to create a new one. The resolution in #454 was that the user is responsible for fixing floats instead of silently fixing the issue. Since the point of ck2yaml is to convert existing CHEMKIN mechanisms to a Cantera format, I would argue that float representations of valid integer flags should be automatically accepted as they are valid CHEMKIN inputs. Manually fixing the geometry flags for mechanisms such as AramcoMech 3.0 (as distributed by NUIGalway) with hundreds of species is unnecessarily tedious.

Version

Cantera 2.6.0a3

Metadata

Metadata

Assignees

No one assigned

    Labels

    InputInput parsing and conversion (for example, ck2yaml)

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions