Feature Request: `f` Binding to run `cargo clippy --fix --allow-dirty`

[micahkepe]

Proposal

Would it be possible to introduce a new default keybind f when running clippy mode to apply Clippy autofixes via cargo clippy --fix --allow-dirty?

Sidenote, absolutely love bacon :)

[Canop]

Are you looking for a new default job doing the --fix, or are you looking for a more complex feature (eg applying the fix on the current diagnostic) ?

[micahkepe]

I was thinking as a new default job.

[Canop]

A new default job looks like a valuable addition, but it's not immediately clear how to make it play well with allow rules being specified in the job command as in https://github.com/Canop/bacon/blob/main/bacon.toml#L89-L102

Regarding a default binding, I'm not sure. Keys are rare so this binding should probably be parameterized by users interested in the autofix feature. I'd welcome feedback from other users.

[c-git]

I'll prefix my answer by saying that I personally don't have a horse in this race because it won't really affect me as I already use f for Rustfmt on nightly because I need nightly for the line wrap but don't use nightly for the actual project.

Pros

• It will make discoverability easier for new users

Cons

• Fix isn't something I personally run often, feels like more of a one off job to me than something I'd mapped to a hotkey
• It is already very easy for a user to add a job as global for their machine by running code "$(bacon --prefs)" (which is where I set things like the job for Rustfmt on nightly)

[Canop]

Same: autofix doesn't fit the way I code. What I could use, what I should probably introduce, is an action like apply_top_fix, so that a shortcut could be defined in any IDE to apply the top suggestion, whatever the tool and command is.

[c-git]

Right I even forgot that it does that. I only ever use fix when changing to a new edition. Right now I'm using vscode and it has a key shortcut to apply fix so I mostly use that I wouldn't want the code automatically changing when I save. I don't actually always agree with the "fix" so I'd want more control over it to undo it.

Edit: Thinking about it more I actually think that would be bad for new users. I always try to apply the principle of least surprise. Your code being changed seems like a surprising thing. Maybe the top fix might not be as bad as that would be only one but would top always match expectations?

[Canop]

The top suggestion would be visible, I assume you'd hit the key after having read it, so it should be safe.

This needs some work first, I need to check that I have that suggestion available in eg the json cargo output.

[c-git]

Ah I see it would be like the open the docs one where it doesn't run on save only on press then goes back to the previous job. Ok that makes more sense.