Revenue pool: deduplicate recipients in batch_distribute and validate against accidental double-pay

[greatest0fallt1me]

Description

RevenuePool::batch_distribute (contracts/revenue_pool/src/lib.rs) sums and transfers each (Address, i128) leg but never checks for duplicate recipients within the same batch. A malformed off-chain payload listing the same developer twice silently double-pays. Add optional duplicate detection and clear semantics.

Requirements and Context

• Detect duplicate to addresses within a single payments vector and either reject or document/merge per agreed policy.
• Keep the existing total-then-transfer atomicity and MAX_BATCH_SIZE cap.
• Emit events reflecting the final per-recipient amount.
• Must be secure, tested, and documented
• Should be efficient and easy to review

Suggested Execution

1. Fork the repo and create a branch

   git checkout -b feature/revenue-pool-dedup-recipients

2. Implement changes
   • contracts/revenue_pool/src/lib.rs — duplicate handling in batch_distribute
   • contracts/revenue_pool/BATCH_TRANSFER_IMPLEMENTATION.md — document policy
3. Test and commit
   • cargo test -p callora-revenue-pool
   • Test duplicate-recipient batches behave per policy
   • Include test output and notes in the PR

Example commit message

feat: handle duplicate recipients in revenue pool batch_distribute

Acceptance Criteria

• Duplicate recipients detected and handled per documented policy
• Atomicity and batch cap preserved
• Events reflect final amounts
• Tests cover duplicate cases

Guidelines

• .rs under contracts/revenue_pool/src/, cargo test, /// docs, minimum 95% line coverage, no unwrap() in prod paths
• Clear documentation and inline comments
• Timeframe: 96 hours

[drips-wave]

@greatest0fallt1me Tenny150 could not be assigned to this issue because they have reached the maximum of 4 accepted assignments per organization in the current wave of the Stellar Wave Program.

The assignee has been removed. Please choose a different contributor.

[nikkybel]

@nikkybel has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Can I be assigned this issue?.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @nikkybel to this issue.

[Emmanuelluxury]

@Emmanuelluxury has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

I’d like to work on this issue because it aligns closely with my experience in blockchain development, smart contract engineering, and full-stack Web3 application development. I enjoy contributing to open-source projects, solving complex technical problems, and building scalable, production-ready solutions that improve developer and user experience.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Emmanuelluxury to this issue.

[drips-wave]

Congratulations, @Emmanuelluxury! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @Emmanuelluxury: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊