Skip to content

Revenue pool: complete missing rustdoc for set_admin and add module-level safety docs #343

@greatest0fallt1me

Description

@greatest0fallt1me

Description

In contracts/revenue_pool/src/lib.rs the doc block above set_admin was clearly mis-merged — the /// comment for the two-step transfer flows directly into get_usdc_token's docs, and set_admin itself carries no dedicated rustdoc. Restore accurate per-function NatSpec-style docs and align them with the emitted admin_changed and admin_transfer_started events.

Requirements and Context

  • Give set_admin its own /// block documenting args, panics, and both emitted events.
  • Fix the stray doc text currently bleeding into get_usdc_token.
  • Verify every pub fn in the crate has complete arg/panic/event docs.
  • Must be secure, tested, and documented
  • Should be efficient and easy to review

Suggested Execution

  1. Fork the repo and create a branch
    git checkout -b task/revenue-pool-rustdoc-fix
  2. Implement changes
    • contracts/revenue_pool/src/lib.rs — correct and complete /// docs
  3. Test and commit
    • cargo doc -p callora-revenue-pool --no-deps
    • cargo clippy -p callora-revenue-pool -- -D warnings
    • Include build output in the PR

Example commit message

docs: restore set_admin rustdoc in revenue pool

Acceptance Criteria

  • set_admin has dedicated, accurate /// docs
  • No doc text bleeds across functions
  • All pub fn documented with args/panics/events
  • cargo doc builds cleanly

Guidelines

  • .rs under contracts/revenue_pool/src/, cargo test, /// docs, minimum 95% line coverage, no unwrap() in prod paths
  • Clear documentation and inline comments
  • Timeframe: 96 hours

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programdocumentationDocumentationrustRust implementationsmart-contractSoroban smart-contract work

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions