Description
In contracts/revenue_pool/src/lib.rs the doc block above set_admin was clearly mis-merged — the /// comment for the two-step transfer flows directly into get_usdc_token's docs, and set_admin itself carries no dedicated rustdoc. Restore accurate per-function NatSpec-style docs and align them with the emitted admin_changed and admin_transfer_started events.
Requirements and Context
- Give
set_admin its own /// block documenting args, panics, and both emitted events.
- Fix the stray doc text currently bleeding into
get_usdc_token.
- Verify every
pub fn in the crate has complete arg/panic/event docs.
- Must be secure, tested, and documented
- Should be efficient and easy to review
Suggested Execution
- Fork the repo and create a branch
git checkout -b task/revenue-pool-rustdoc-fix
- Implement changes
contracts/revenue_pool/src/lib.rs — correct and complete /// docs
- Test and commit
cargo doc -p callora-revenue-pool --no-deps
cargo clippy -p callora-revenue-pool -- -D warnings
- Include build output in the PR
Example commit message
docs: restore set_admin rustdoc in revenue pool
Acceptance Criteria
Guidelines
.rs under contracts/revenue_pool/src/, cargo test, /// docs, minimum 95% line coverage, no unwrap() in prod paths
- Clear documentation and inline comments
- Timeframe: 96 hours
Description
In
contracts/revenue_pool/src/lib.rsthe doc block aboveset_adminwas clearly mis-merged — the///comment for the two-step transfer flows directly intoget_usdc_token's docs, andset_adminitself carries no dedicated rustdoc. Restore accurate per-function NatSpec-style docs and align them with the emittedadmin_changedandadmin_transfer_startedevents.Requirements and Context
set_adminits own///block documenting args, panics, and both emitted events.get_usdc_token.pub fnin the crate has complete arg/panic/event docs.Suggested Execution
contracts/revenue_pool/src/lib.rs— correct and complete///docscargo doc -p callora-revenue-pool --no-depscargo clippy -p callora-revenue-pool -- -D warningsExample commit message
Acceptance Criteria
set_adminhas dedicated, accurate///docspub fndocumented with args/panics/eventscargo docbuilds cleanlyGuidelines
.rsundercontracts/revenue_pool/src/,cargo test,///docs, minimum 95% line coverage, nounwrap()in prod paths