From ad5cb9263ecd3b32523f980f467e8f6fe2e5367a Mon Sep 17 00:00:00 2001 From: Nathaniel Brough Date: Wed, 31 Dec 2025 16:27:38 +1000 Subject: [PATCH] fix: Allow duplicate sub-assemblies --- cadquery/assembly.py | 5 ++--- tests/test_assembly.py | 6 ------ 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/cadquery/assembly.py b/cadquery/assembly.py index 72b2657d1..819310a42 100644 --- a/cadquery/assembly.py +++ b/cadquery/assembly.py @@ -244,9 +244,8 @@ def add(self, arg, **kwargs): # enforce unique names name = kwargs["name"] if kwargs.get("name") else arg.name if name in self.objects: - raise ValueError( - f"Unique name is required. {name} is already in the assembly" - ) + # Add a incremented number to the name + name = f"{name}_{len(self.objects)}" subassy = arg._copy() diff --git a/tests/test_assembly.py b/tests/test_assembly.py index efed11b86..7b16727e6 100644 --- a/tests/test_assembly.py +++ b/tests/test_assembly.py @@ -1792,12 +1792,6 @@ def test_constrain_with_tags(nested_assy): nested_assy.constrain("SECOND/BOTTOM ? pts", "dummy", "Plane") -def test_duplicate_name(nested_assy): - - with pytest.raises(ValueError): - nested_assy.add(None, name="SECOND") - - def test_empty_solve(nested_assy): with pytest.raises(ValueError):