Add image support

[tippfehlr]

Display images in terminals that support it.

ratatui-image1 could be a simple solution.

Checklist

• checked that this feature wasn't requested before in an issue
• read CONTRIBUTING.md

[Builditluc]

Hey @tippfehlr, thanks for your feature request.
Implementing inline image rendering list has been on my todo list for a while now.

I don't think it would be that simple integrating images into the rendering pipeline, but I'll work up a poc.

The feature however would need to be behind a feature-flag or at toggle-able in the config, since not all terminals support inline image rendering.

[tippfehlr]

It would be great if it could autodetect if the current terminal supports images. ratatui-image apparently has autodetection and falls back to colored blocks.

I'd propose to display images by default if the terminal supports an image protocol and hide them otherwise (don't display colored blocks).
Turning (blocky) images on or off could then be configured.

[0323pin]

The feature however would need to be behind a feature-flag ...

Yes, please.

... falls back to colored blocks

No, please

A compile feature-flag would be my preferred choice.

[tippfehlr]

@0323pin I don’t want blocky images either.
A compile-time feature-flag is inconvenient for everyone installing wiki-tui from repos.
What do you have against detecting terminal support?

[0323pin]

I'd propose to display images by default if the terminal supports an image protocol and hide them otherwise (don't display colored blocks).
Turning (blocky) images on or off could then be configured.

Ok

I don't like images in the terminal, that's all.
Fortunately, I use a terminal that doesn't support image rendering.

[techieshark]

+1 for this. There is some info that is missing, in addition to just images;

See for example the entry for 'rocket':

And in wiki-tui it results in <Unsupported Element 'Figure'>:

and note that the <Figure> includes a caption, which is missing in the text interface.

Rather than showing the image itself, perhaps there's a way to show:

• the alt text or figure caption
• a link for the image

and then the image itself could be opened in a new layer, if the terminal supports it

[jeslinmx]

Having the image open on a separate layer makes a lot of sense:

• Graceful degradation for unsupported terminals - either activating the caption/figure placeholder does nothing, or downloads it to /tmp and xdg-opens it, or opens it in a browser
• I'm going to hazard a guess that adding image display into a separate window/layer is less involved than integrating it into the main text window, which introduces all sort of reflowing and layout challenges.
• reduced bandwidth consumption and visual clutter, since images can be loaded only when they are viewed

[max-gaspers-scott]

I'll take this if there are no objections. I'll have images be opened in there own layer for the reasons stated above by @jeslinmx and @techieshark