Skip to content

Commit 0af5593

Browse files
authored
Merge pull request #607 from BloomBooks/BL14915_NoComicFeature
Remove comic feature (BL-14915) (#607)
2 parents 108a67b + cac53f3 commit 0af5593

5 files changed

Lines changed: 3 additions & 33 deletions

File tree

src/assets/Comic.svg

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/components/BookCard.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export const Simple: Story = {
4949
"blind",
5050
"blind:en",
5151
"activity",
52-
"comic",
5352
],
5453
license: "",
5554
copyright: "",

src/components/FeatureHelper.tsx

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React from "react";
22
import ActivityIcon from "../assets/Activity.svg?react";
3-
import ComicIcon from "../assets/Comic.svg?react";
43
import MotionIcon from "../assets/Motion.svg?react";
54
import SignLanguageIcon from "../assets/Sign Language.svg?react";
65
import TalkingBookIcon from "../assets/Talking Book.svg?react";
@@ -36,7 +35,7 @@ export const featureIconHeight = 12;
3635
// (appears next to the language in the languages list) or not (appears on the left of the
3736
// feature bar). In addition, the icon is given as a function that takes some props and
3837
// returns a react component.
39-
// It would be simpler to, e.g., import comicIcon from "../assets/Comic.svg?react"
38+
// It would be simpler to, e.g., import someIcon from "../assets/Some.svg?react"
4039
// (which yields a url), then let the icon: simply be that string, and let the code
4140
// that wants the icon make an <img> with src={feature.icon}. But then we can't use
4241
// fill: to control the color.
@@ -102,28 +101,6 @@ export const featureSpecs: IFeatureSpec[] = [
102101
languageDependent: true,
103102
englishLabel: "Features for the Visually Impaired",
104103
},
105-
{
106-
featureKey: "comic",
107-
//featureTitle: "Comic Books",
108-
filter: { feature: "comic" },
109-
// description: (
110-
// <div>
111-
// Comic Books contain comic speech bubbles, captions, and/or other
112-
// text which appears over images.
113-
// </div>
114-
// ),
115-
icon(props) {
116-
return (
117-
<ComicIcon
118-
title={getLocalizedLabel(this)}
119-
{...props}
120-
></ComicIcon>
121-
);
122-
},
123-
languageDependent: false,
124-
collectionHref: "comics",
125-
englishLabel: "Comic Book",
126-
},
127104
{
128105
featureKey: "motion",
129106
//featureTitle: "Motion Books",

src/model/SpecialSearch.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ const cases = [
1919
["bible comic", "super-bible"],
2020
["bible comics", "super-bible"],
2121
["grid", "grid"],
22-
["comic book", "comics"],
23-
["german", "language:de"],
2422
["motion book", "motion"],
23+
["sign language", "sign-language"],
24+
["german", "language:de"],
2525
["swahili", "language:swh"],
2626
["spanish", "language:es"],
2727
];

src/translations/BloomLibrary.org/Topics And Features.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@
6262
"feature.blind": {
6363
"message": "Features for the Visually Impaired"
6464
},
65-
"feature.comic": {
66-
"message": "Comic Book"
67-
},
6865
"feature.motion": {
6966
"message": "Motion Book"
7067
},

0 commit comments

Comments
 (0)