Skip to content

v1.0.0#250

Merged
rebelinux merged 12 commits into
AsBuiltReport:devfrom
rebelinux:dev
Apr 24, 2026
Merged

v1.0.0#250
rebelinux merged 12 commits into
AsBuiltReport:devfrom
rebelinux:dev

Conversation

@rebelinux
Copy link
Copy Markdown
Collaborator

[1.0.0] - 2026-04-24

Added

  • Add support for GliderUI graphical interface to generate reports via an intuitive user interface instead of command-line execution. The GUI enables users to select target domains, customize report options (InfoLevel, HealthChecks, diagram settings), and initiate report generation with a streamlined, user-friendly experience, reducing friction for non-technical stakeholders.

🔃 Changed

  • Improved multi-language support by refactoring localization strings and enhancing documentation clarity in MicrosoftAD.psd1 for English and Spanish languages.
    This includes improved grammar, punctuation, and readability across various best practice descriptions related to Active Directory configurations
  • Bump module version to 1.0.0
  • Upgrade AsBuiltReport.Diagram module to version 1.0.6
  • Upgrade AsBuiltReport.Chart module to version 0.3.1

🐛 Fixed

  • Fix diagram theme generation not respecting the selected theme in the configuration file, ensuring that diagrams are rendered with the correct visual style as defined by the user.

rebelinux and others added 12 commits April 5, 2026 13:18
… translation functions for improved localization and clarity. Updated messages in Get-AbrADInfrastructureService.ps1, Get-AbrADKerberosAudit.ps1, Get-AbrADOU.ps1, Get-AbrADReportBrief.ps1, Get-AbrADSCCM.ps1, Get-AbrADSecurityAssessment.ps1, Get-AbrADSite.ps1, Get-AbrADSiteReplication.ps1, Get-AbrADTrust.ps1, Get-AbrDHCPinAD.ps1, Get-AbrDNSSection.ps1, Get-AbrDomainSection.ps1, and Invoke-DcDiag.ps1.
…erface

fix: Ensure diagram theme generation respects user-selected themes in configuration

refactor: Improve multi-language support and documentation clarity for MicrosoftAD.psd1
…ty and user-friendliness

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 24, 2026 20:53
Comment thread AsBuiltReport.Microsoft.AD/Src/Private/Gui/Start-AsBuiltReportMSAD.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Private/Report/Get-AbrDomainSection.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Dismissed
Comment thread AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Dismissed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Release-oriented PR that bumps AsBuiltReport.Microsoft.AD to v1.0.0, adds a GliderUI-based GUI launcher for generating reports, and improves localization and diagram theming across the reporting/diagram pipeline.

Changes:

  • Added GUI entrypoint (Start-AsBuiltReportMSAD) and updated module exports/loader to include GUI scripts.
  • Refactored many user-facing strings to use localization resources (en-US / es-ES) and improved wording/consistency.
  • Updated diagram rendering to better respect configured theme colors (passing background colors through diagram label/table helpers), plus version/dependency bumps and doc updates.

Reviewed changes

Copilot reviewed 53 out of 54 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
copilot-instructions.md Removed repository-specific Copilot instruction document.
README.md Added GUI usage section and screenshot reference.
CHANGELOG.md Added v1.0.0 release notes.
AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 Version bump and localized/normalized console output formatting.
AsBuiltReport.Microsoft.AD/Src/Private/Gui/Start-AsBuiltReportMSAD.ps1 New GUI launcher implementation (GliderUI/Avalonia).
AsBuiltReport.Microsoft.AD/Src/Private/Report/* Large sweep converting hardcoded messages/table names to $reportTranslate keys and improving error/context strings.
AsBuiltReport.Microsoft.AD/Src/Private/Diagram/* Theme-related adjustments by passing background colors into diagram label/table builders.
AsBuiltReport.Microsoft.AD/Language/en-US/MicrosoftAD.psd1 Added/updated translation keys used by the refactor.
AsBuiltReport.Microsoft.AD/Language/es-ES/MicrosoftAD.psd1 Added/updated Spanish translation keys used by the refactor.
AsBuiltReport.Microsoft.AD/AsBuiltReport.Microsoft.AD.psm1 Added dot-sourcing of Src/Private/Gui and exporting GUI functions.
AsBuiltReport.Microsoft.AD/AsBuiltReport.Microsoft.AD.psd1 Version bump, dependency bumps, and exported function list updated to include GUI.
AsBuiltReport.Microsoft.AD/AsBuiltReport.Microsoft.AD.json Removed CA HealthCheck defaults from the config.

Comment thread README.md

**Beta** versions of the GUI may contain bugs and issues. If you encounter any problems while using the GUI, please report them on the project's GitHub Issues page.

![alt text](Samples/Sample-Gui.png)
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Markdown image uses a non-descriptive alt text (alt text). For accessibility and better rendering in non-image contexts, use a meaningful description (e.g., what the screenshot shows).

Copilot uses AI. Check for mistakes.
try {
if ($DomainInfo = Invoke-CommandWithTimeout -Session $TempPssSession -ScriptBlock { Get-ADDomain -Identity $using:Domain }) {
Write-Host " - Collecting Domain information from $Domain."
Write-Host ([string]::Format(" - $($reportTranslate.GetAbrDomainSection.CollectingDomain)", $Domain))
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report section uses Write-Host for progress output. Write-Host bypasses PScribo/AsBuiltReport logging and can’t be suppressed or redirected consistently; use Write-PScriboMessage (or Write-Information if intentional) to align with the rest of the module’s logging behavior (e.g., Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 uses Write-Host only at the entry point).

Copilot uses AI. Check for mistakes.
Comment on lines +38 to +41
if (-not (Get-Module -ListAvailable -Name GliderUI)) {
Write-Host 'GliderUI not found — installing from PSGallery…' -ForegroundColor Cyan
Install-PSResource -Name GliderUI -Version $requiredGliderUIVersion -Scope CurrentUser -TrustRepository
}
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GUI bootstrapping auto-installs GliderUI from PSGallery and uses -TrustRepository, which implicitly trusts the repository without user confirmation. This is a supply-chain risk for an interactive tool; consider prompting the user and/or removing -TrustRepository (or validating source/signatures) so installs remain explicit and auditable.

Copilot uses AI. Check for mistakes.
$requiredGliderUIVersion = [version]'0.2.0'

if (-not (Get-Module -ListAvailable -Name GliderUI)) {
Write-Host 'GliderUI not found — installing from PSGallery…' -ForegroundColor Cyan
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This private GUI function uses Write-Host for status/error output. For consistency with the module’s logging approach, prefer Write-PScriboMessage/Write-Information (and Write-Error for errors) rather than Write-Host, which can’t be captured or suppressed reliably.

Suggested change
Write-Host 'GliderUI not found — installing from PSGallery…' -ForegroundColor Cyan
Write-PScriboMessage -Message 'GliderUI not found — installing from PSGallery…'

Copilot uses AI. Check for mistakes.

$TableParams = @{
Name = "$($reportTranslate.GetAbrADSite.ConnectionObjects) - $($ForestInfo)"
Name = "$($reportTranslate.GetAbrADSite.ConnectionObjects)- $($ForestInfo)"
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table name formatting appears to have lost the space before the hyphen ("...ConnectionObjects)- ..."). This will render oddly in report output; it likely should match the common " - " pattern used elsewhere.

Copilot uses AI. Check for mistakes.
$List.Add($reportTranslate.GetAbrADSite.DescBP)
}
if ($OutObj | Where-Object { $_.$($reportTranslate.GetAbrADSite.Sites) -eq $reportTranslate.GetAbrADSite.NoSiteAssigned }) {
if ($OutObj | Where-Object { $_.$($reportTranslate.GetAbrADSite.Sites) -eq $reportTranslate.GetAbrADSite.NoSiteAssigned }){
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the opening brace in the if statement (...NoSiteAssigned }){) breaks consistent whitespace and may trigger PSScriptAnalyzer formatting rules. Add the space before { to keep style consistent.

Copilot uses AI. Check for mistakes.
@rebelinux rebelinux merged commit 30b31ea into AsBuiltReport:dev Apr 24, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants