dnspython commit rthalley/dnspython@6309fcf0, first included in release 1.13.0, breaks the test wpull.util_test.TestUtil.test_get_exception_message. Example failing build from #413: https://travis-ci.org/ArchiveTeam/wpull/jobs/504035201
It's worth mentioning that this test doesn't seem to actually break any functionality; most (if not all) ArchiveBot pipelines use version 1.15.0 without issues (aside from the crashes which should be fixed with 1.16.0, #365). It would be very worrying if wpull used the return value of that get_exception_message method anywhere except for logging, also.
However, I think the test is broken, namely it shouldn't rely on any external exception classes but directly contain the relevant examples.
dnspython commit rthalley/dnspython@6309fcf0, first included in release 1.13.0, breaks the test
wpull.util_test.TestUtil.test_get_exception_message. Example failing build from #413: https://travis-ci.org/ArchiveTeam/wpull/jobs/504035201It's worth mentioning that this test doesn't seem to actually break any functionality; most (if not all) ArchiveBot pipelines use version 1.15.0 without issues (aside from the crashes which should be fixed with 1.16.0, #365). It would be very worrying if wpull used the return value of that
get_exception_messagemethod anywhere except for logging, also.However, I think the test is broken, namely it shouldn't rely on any external exception classes but directly contain the relevant examples.