Work around the change in tornadoweb/tornado@84bb2e28

According to that commit, there is a 200 ms delay on macOS when connecting to localhost and only IPv4 is bound (which is what Tornado does). For that reason, they replaced "localhost" with "127.0.0.1" in tornado.testing.AsyncHTTPTestCase.get_url.
Because wpull treats "localhost" and "127.0.0.1" as different hosts, this breaks a variety of tests for different reasons (URLs getting skipped, cookies not set, etc.) when using Tornado 4.5.3.
As a workaround, this commit restores the previous behaviour of using "localhost". This may incur a performance penalty during testing on some platforms.

Author: JustAnotherArchivist

wpull/testing/goodapp.py

@@ -7,11 +7,11 @@
 import os.path
 import time
 
-from tornado.testing import AsyncHTTPTestCase, AsyncHTTPSTestCase
 from tornado.web import HTTPError
 import tornado.web
 
 from wpull.testing.async import AsyncTestCase
+from wpull.testing.util import AsyncHTTPTestCase, AsyncHTTPSTestCase
 
 
 _logger = logging.getLogger(__name__)

wpull/testing/integration/base.py

@@ -3,14 +3,13 @@
 
 import asyncio
 import tornado.web
-from tornado.testing import AsyncHTTPSTestCase
 import tornado.ioloop
 
 from wpull.testing.async import AsyncTestCase
 from wpull.testing.badapp import BadAppTestCase
 from wpull.testing.ftp import FTPTestCase
 from wpull.testing.goodapp import GoodAppTestCase
-from wpull.testing.util import TempDirMixin
+from wpull.testing.util import TempDirMixin, AsyncHTTPSTestCase
 
 
 class AppTestCase(AsyncTestCase, TempDirMixin):

wpull/testing/util.py

@@ -2,6 +2,7 @@
 import logging
 import os
 from tempfile import TemporaryDirectory
+import tornado.testing
 
 _logger = logging.getLogger(__name__)
 
@@ -30,3 +31,22 @@ def cd_tempdir(self):
                 yield temp_dir
             finally:
                 os.chdir(original_dir)
+
+
+class GetUrlFixMixin:
+    # A mixin to undo the change in tornado@84bb2e28 which replaces localhost with 127.0.0.1.
+    # https://github.com/tornadoweb/tornado/commit/84bb2e285e15415bb86cbdf2326b19f0debb80fd
+
+    def get_url(self, *args, **kwargs):
+        r = super().get_url(*args, **kwargs)
+        if '//127.0.0.1:' in r:
+            r = r.replace('127.0.0.1', 'localhost', 1)
+        return r
+
+
+class AsyncHTTPTestCase(GetUrlFixMixin, tornado.testing.AsyncHTTPTestCase):
+    pass
+
+
+class AsyncHTTPSTestCase(GetUrlFixMixin, tornado.testing.AsyncHTTPSTestCase):
+    pass