feat(topology): track per-shard row counts#3
Closed
gtarraga wants to merge 2 commits into
Closed
Conversation
Ankcorn
reviewed
Jan 1, 2026
| } | ||
|
|
||
| if (deltaByShard.size > 0) { | ||
| await topologyStub.batchBumpTableShardRowCounts(tableName, deltaByShard); |
Owner
There was a problem hiding this comment.
I'm not too sure we want to be going back and tracking this in the topology, it's going to add an extra DO operation which increases cost. The topology is also a single point of failure and increasing writes to it will lower our total possible throughput
Contributor
Author
There was a problem hiding this comment.
Ahh, I didnt realise about the new DO storage costs. Lets scrap this then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
row_countcolumn totable_shardstable