diff --git a/src/Cake.NUnitRetry.Tests/NUnit3DeserializerTests.cs b/src/Cake.NUnitRetry.Tests/NUnit3DeserializerTests.cs index 412253b..7910372 100644 --- a/src/Cake.NUnitRetry.Tests/NUnit3DeserializerTests.cs +++ b/src/Cake.NUnitRetry.Tests/NUnit3DeserializerTests.cs @@ -8,7 +8,6 @@ namespace Cake.NUnitRetry.Tests { - [TestFixture] public sealed class NUnit3DeserializerTests { public sealed class TheConstructor @@ -46,11 +45,11 @@ public void ReturnsTheExpectedTestRunResults() var fixture = new NUnit3XmlReaderFixture(); TestRun results = fixture.ParseTestRunResultsNUnit3(); - Assert.AreEqual(results.Total, 18, "Wrong total amount"); - Assert.AreEqual(results.Passed, 12, "Wrong passed amount"); - Assert.AreEqual(results.Failed, 2, "Wrong failed amount"); - Assert.AreEqual(results.Inconclusive, 1, "Wrong inconclusive amount"); - Assert.AreEqual(results.Skipped, 3, "Wrong skipped amount"); + Assert.AreEqual(18, results.Total, "Wrong total amount"); + Assert.AreEqual(12, results.Passed, "Wrong passed amount"); + Assert.AreEqual(2, results.Failed, "Wrong failed amount"); + Assert.AreEqual(1, results.Inconclusive, "Wrong inconclusive amount"); + Assert.AreEqual(3, results.Skipped, "Wrong skipped amount"); Assert.AreEqual(results.Passed, results.TestCases.Count(x => x.Result == Result.Passed), "Wrong passed test cases amount"); Assert.AreEqual(results.Failed, results.TestCases.Count(x => x.Result == Result.Failed), "Wrong failed test cases amount"); diff --git a/src/Cake.NUnitRetry.Tests/TestListWriterTests.cs b/src/Cake.NUnitRetry.Tests/TestListWriterTests.cs index 5c7521c..5885d95 100644 --- a/src/Cake.NUnitRetry.Tests/TestListWriterTests.cs +++ b/src/Cake.NUnitRetry.Tests/TestListWriterTests.cs @@ -8,9 +8,9 @@ namespace Cake.NUnitRetry.Tests { - [TestFixture] public class TestListWriterTests { + [TestFixture] public sealed class TheConstructor { [Test] @@ -34,6 +34,7 @@ public void ThrowsIfEnvironmentIsNull() } } + [TestFixture] public class TheWriteMethod { private readonly FilePath _testListFile = "/Working/testlist.txt"; diff --git a/src/Cake.NUnitRetry.Tests/XmlResultUpdaterTests.cs b/src/Cake.NUnitRetry.Tests/XmlResultUpdaterTests.cs index d8db8f1..09c71e5 100644 --- a/src/Cake.NUnitRetry.Tests/XmlResultUpdaterTests.cs +++ b/src/Cake.NUnitRetry.Tests/XmlResultUpdaterTests.cs @@ -34,7 +34,7 @@ public void UpdatesAFailedTestWhenItsFixed() var parser = new XmlParser(_fileSystem, _environment); - var updater = new XmlResultUpdater(parser, _fileSystem, _environment); + var updater = new XmlResultUpdater(parser, _fileSystem); updater.Update(_failedResultPath, _failedResultFixedPath); var results = _parser.Parse(_failedResultPath); @@ -53,7 +53,7 @@ public void UpdatesMultipleFailedTestsWhenItsFixed() var parser = new XmlParser(_fileSystem, _environment); - var updater = new XmlResultUpdater(parser, _fileSystem, _environment); + var updater = new XmlResultUpdater(parser, _fileSystem); updater.Update(_failedResultPath, _failedResultFixedPath); var results = _parser.Parse(_failedResultPath); diff --git a/src/Cake.NUnitRetry/XmlResultUpdater.cs b/src/Cake.NUnitRetry/XmlResultUpdater.cs index af12aa7..513f125 100644 --- a/src/Cake.NUnitRetry/XmlResultUpdater.cs +++ b/src/Cake.NUnitRetry/XmlResultUpdater.cs @@ -10,23 +10,16 @@ public class XmlResultUpdater { private readonly XmlParser _parser; private readonly IFileSystem _fileSystem; - private readonly ICakeEnvironment _environment; - public XmlResultUpdater(XmlParser xmlParser, IFileSystem fileSystem, ICakeEnvironment environment) + public XmlResultUpdater(XmlParser xmlParser, IFileSystem fileSystem) { if (fileSystem == null) { throw new ArgumentNullException(nameof(fileSystem)); } - if (environment == null) - { - throw new ArgumentNullException(nameof(environment)); - } - _parser = xmlParser; _fileSystem = fileSystem; - _environment = environment; } public void Update(FilePath resultsToUpdatePath, FilePath updateSourcePath)