Skip to content

Commit 14f3e55

Browse files
committed
All libraries shall go to lib64
1 parent 3fb50e5 commit 14f3e55

File tree

9 files changed

+43
-9
lines changed

9 files changed

+43
-9
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake)
1515

1616
include(CMakeParseArguments)
1717
include(QCModulesUtils)
18+
include(GNUInstallDirs)
1819

1920
# ---- Project ----
2021

Framework/CMakeLists.txt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ root_generate_dictionary("${dict}" ${HEADERS} LINKDEF include/QualityControl/Lin
9999
# TODO review how and what to install for dictionary
100100
install(
101101
FILES ${CMAKE_CURRENT_BINARY_DIR}/lib${dict}_rdict.pcm ${CMAKE_CURRENT_BINARY_DIR}/lib${dict}.rootmap
102-
DESTINATION lib
102+
DESTINATION ${CMAKE_INSTALL_LIBDIR}
103103
)
104104

105105
# ---- Library ----
@@ -233,21 +233,19 @@ endforeach()
233233

234234
# ---- Install ----
235235

236-
include(GNUInstallDirs)
237-
238236
# Build targets with install rpath on Mac to dramatically speed up installation
239237
# https://gitlab.kitware.com/cmake/community/wikis/doc/cmake/RPATH-handling
240238
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
241-
list(FIND CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES "${CMAKE_INSTALL_PREFIX}/lib" isSystemDir)
239+
list(FIND CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}" isSystemDir)
242240
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
243241
if("${isSystemDir}" STREQUAL "-1")
244-
set(CMAKE_INSTALL_RPATH "@loader_path/../lib")
242+
set(CMAKE_INSTALL_RPATH "@loader_path/../${CMAKE_INSTALL_LIBDIR}")
245243
endif()
246244
set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
247245
endif()
248246
unset(isSystemDir)
249247

250-
# Install library
248+
# Install library and header
251249
install(
252250
TARGETS QualityControl ${EXE_NAMES} tobject2json
253251
EXPORT QualityControlTargets

Framework/readoutChainTemplate.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"password": "qc_user",
1414
"name": "quality_control",
1515
"implementation": "CCDB",
16-
"host": "localhost:8080"
16+
"host": "ccdb-test.cern.ch:8080"
1717
},
1818
"Activity": {
1919
"number": "42",
@@ -30,7 +30,7 @@
3030
"moduleOfChecks": "QcExample",
3131
"outputDataOrigin": "ITS",
3232
"cycleDurationSeconds": "10",
33-
"maxNumberCycles": "-1",
33+
"maxNumberCycles": "10",
3434
"outputDataDescription": "HIST_SKLT_TASK",
3535
"inputs": "readoutInput",
3636
"fraction": "0.01",

Modules/Common/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ target_include_directories(
3434

3535
target_link_libraries(${MODULE_NAME} PUBLIC QualityControl PRIVATE ROOT::Graf)
3636

37+
install(
38+
TARGETS ${MODULE_NAME}
39+
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
40+
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
41+
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
42+
)
43+
3744
# ---- ROOT dictionary ----
3845

3946
generate_root_dict(MODULE_NAME ${MODULE_NAME} LINKDEF "include/Common/LinkDef.h" DICT_CLASS "${MODULE_NAME}Dict")

Modules/Daq/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,13 @@ target_include_directories(
2626

2727
target_link_libraries(${MODULE_NAME} PUBLIC QualityControl PRIVATE ROOT::Gpad)
2828

29+
install(
30+
TARGETS ${MODULE_NAME}
31+
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
32+
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
33+
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
34+
)
35+
2936
# ---- ROOT dictionary ----
3037

3138
generate_root_dict(MODULE_NAME ${MODULE_NAME} LINKDEF "include/Daq/LinkDef.h" DICT_CLASS "${MODULE_NAME}Dict")

Modules/Example/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,13 @@ target_include_directories(
2828

2929
target_link_libraries(${MODULE_NAME} PUBLIC QualityControl)
3030

31+
install(
32+
TARGETS ${MODULE_NAME}
33+
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
34+
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
35+
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
36+
)
37+
3138
# ---- ROOT dictionary ----
3239

3340
generate_root_dict(MODULE_NAME ${MODULE_NAME} LINKDEF "include/Example/LinkDef.h" DICT_CLASS "${MODULE_NAME}Dict")

Modules/Skeleton/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,13 @@ target_include_directories(
2626

2727
target_link_libraries(${MODULE_NAME} PUBLIC QualityControl)
2828

29+
install(
30+
TARGETS ${MODULE_NAME}
31+
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
32+
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
33+
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
34+
)
35+
2936
# ---- ROOT dictionary ----
3037

3138
generate_root_dict(MODULE_NAME ${MODULE_NAME} LINKDEF "include/Skeleton/LinkDef.h" DICT_CLASS "${MODULE_NAME}Dict")

Modules/SkeletonDPL/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,13 @@ target_include_directories(
2626

2727
target_link_libraries(${MODULE_NAME} PUBLIC QualityControl)
2828

29+
install(
30+
TARGETS ${MODULE_NAME}
31+
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
32+
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
33+
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
34+
)
35+
2936
# ---- ROOT dictionary ----
3037

3138
generate_root_dict(MODULE_NAME ${MODULE_NAME} LINKDEF "include/SkeletonDPL/LinkDef.h" DICT_CLASS "${MODULE_NAME}Dict")

cmake/QCModulesUtils.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function(GENERATE_ROOT_DICT)
6464
# TODO review how and what to install for dictionary
6565
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/lib${PARSED_ARGS_MODULE_NAME}Dict_rdict.pcm
6666
${CMAKE_CURRENT_BINARY_DIR}/lib${PARSED_ARGS_MODULE_NAME}Dict.rootmap
67-
DESTINATION lib)
67+
DESTINATION ${CMAKE_INSTALL_LIBDIR})
6868

6969
endfunction()
7070

0 commit comments

Comments
 (0)