diff --git a/app/__init__.py b/app/__init__.py index 3c581ceeb..35fff9f6c 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,6 +1,10 @@ + from flask import Flask from .db import db, migrate from .models import task, goal +from app.routes.task_routes import bp as task_bp +from app.routes.goal_routes import bp as goal_bp + import os def create_app(config=None): @@ -18,5 +22,8 @@ def create_app(config=None): migrate.init_app(app, db) # Register Blueprints here + app.register_blueprint(task_bp) + app.register_blueprint(goal_bp) + return app diff --git a/app/models/goal.py b/app/models/goal.py index 44282656b..290ba626b 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,34 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship from ..db import db +from typing import TYPE_CHECKING +if TYPE_CHECKING: + from .task import Task + + class Goal(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title: Mapped[str] + tasks: Mapped[list["Task"]] = relationship(back_populates="goal") + + def to_dict(self, include_empty_tasks=False): + goal_as_dict = {} + goal_as_dict["id"] = self.id + goal_as_dict["title"] = self.title + + if self.tasks: + goal_as_dict["tasks"] = [task.to_dict() for task in self.tasks] + if not self.tasks and include_empty_tasks == True: + goal_as_dict["tasks"] = [] + + return goal_as_dict + + # def to_dict_mandatory_tasks_list(self): + # goal_as_dict = self.to_dict() + # goal_as_dict["tasks"] = [task.to_dict() for task in self.tasks] + # return goal_as_dict + + + @classmethod + def from_dict(cls, goal_data): + return cls(title=goal_data["title"]) \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index 5d99666a4..4b7118ba6 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,34 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship +from sqlalchemy import ForeignKey +from datetime import datetime +from typing import Optional from ..db import db +from typing import TYPE_CHECKING +if TYPE_CHECKING: + from .goal import Goal + + class Task(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title: Mapped[str] + description: Mapped[str] + completed_at: Mapped[datetime] = mapped_column(nullable=True) + goal_id: Mapped[Optional[int]] = mapped_column(ForeignKey("goal.id")) + goal: Mapped["Goal"] = relationship(back_populates="tasks") + + def to_dict(self): + task_as_dict = {} + task_as_dict["id"] = self.id + task_as_dict["title"] = self.title + task_as_dict["description"] = self.description + task_as_dict["is_complete"] = False if not self.completed_at else True + + if self.goal: + task_as_dict["goal_id"] = self.goal.id + + return task_as_dict + + @classmethod + def from_dict(cls, dict_data): + return cls(title=dict_data["title"], description=dict_data["description"]) \ No newline at end of file diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py index 3aae38d49..8bf9afcf4 100644 --- a/app/routes/goal_routes.py +++ b/app/routes/goal_routes.py @@ -1 +1,76 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, request, Response, make_response, abort +from sqlalchemy import desc +from datetime import datetime, timezone +import requests +from app.routes.routes_helper_utilities import create_model_inst_from_dict_with_response, retrieve_model_inst_by_id, nested_dict +from app.models.task import Task +from app.models.goal import Goal +from app.db import db + +bp = Blueprint("goal_bp", __name__, url_prefix="/goals") + +# POST ONE GOAL, RETURN {"GOAL": {GOAL DICTIONARY}} +@bp.post("") +def create_goal(): + request_body = request.get_json() + return create_model_inst_from_dict_with_response(Goal, request_body) + +# ADD EXISTING TASK IDS TO EXISTING GOAL, RETURN {"ID":..., "TASK_IDS": [...]} +@bp.post("//tasks") +def add_task_ids_to_goal(goal_id): + goal = retrieve_model_inst_by_id(Goal, goal_id) + request_body = request.get_json() + + # remove connection of existing task from that goal + query = db.select(Task).where(Task.goal_id==1) + old_tasks = db.session.scalars(query) + for task in old_tasks: + task.goal_id = None + + # add connections of new tasks to the goal + for task_id in request_body["task_ids"]: + task = retrieve_model_inst_by_id(Task, task_id) + task.goal_id = goal_id + + db.session.commit() + return {"id": int(goal_id), + "task_ids": [task.id for task in goal.tasks]} + +# GET TASKS FOR ONE GOAL, RETURN GOAL DICTIONARY WITH TASKS LIST +@bp.get("//tasks") +def get_tasks_of_one_goal(goal_id): + goal = retrieve_model_inst_by_id(Goal, goal_id) + return goal.to_dict(include_empty_tasks=True) + +# GET ALL GOALS +@bp.get("") +def get_saved_goals(): + goals = db.session.scalars(db.select(Goal).order_by(Goal.id)) + return [goal.to_dict() for goal in goals] + +# GET GOAL BY ID +@bp.get("/") +def get_one_goal(goal_id): + goal = retrieve_model_inst_by_id(Goal, goal_id) + return nested_dict(Goal, goal) + +# UPDATE GOAL TITLE +@bp.put("/") +def update_one_goal(goal_id): + goal = retrieve_model_inst_by_id(Goal, goal_id) + request_body = request.get_json() + + goal.title = request_body["title"] + db.session.commit() + return Response(status=204, mimetype="application/json") + +# DELETE ONE GOAL +@bp.delete("/") +def delete_one_goal(goal_id): + goal = retrieve_model_inst_by_id(Goal, goal_id) + db.session.delete(goal) + db.session.commit() + + return Response(status=204, mimetype="application/json") + + diff --git a/app/routes/routes_helper_utilities.py b/app/routes/routes_helper_utilities.py new file mode 100644 index 000000000..9b0c55f1a --- /dev/null +++ b/app/routes/routes_helper_utilities.py @@ -0,0 +1,34 @@ +from flask import abort, make_response +from app.db import db + +def retrieve_model_inst_by_id(cls, model_id): + try: + model_id = int(model_id) + except: + response_message = {"message": f"{cls.__name__} id <{model_id}> is invalid."} + abort(make_response(response_message, 400)) + + query = db.select(cls).where(cls.id == model_id) + model = db.session.scalar(query) + + if not model: + response_message = {"message": f"{cls.__name__} with id <{model_id}> is not found."} + abort(make_response(response_message, 404)) + + return model + +def create_model_inst_from_dict_with_response(cls, inst_data): + try: + new_instance = cls.from_dict(inst_data) + except KeyError as error: + response = {"details": "Invalid data"} + abort(make_response(response, 400)) + + db.session.add(new_instance) + db.session.commit() + response = {f"{cls.__name__.lower()}": new_instance.to_dict()} + return response, 201 + +def nested_dict(cls, instance): + return {f"{cls.__name__.lower()}": instance.to_dict()} + \ No newline at end of file diff --git a/app/routes/task_routes.py b/app/routes/task_routes.py index 3aae38d49..20b9f8c9a 100644 --- a/app/routes/task_routes.py +++ b/app/routes/task_routes.py @@ -1 +1,131 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, request, Response, make_response, abort +from sqlalchemy import desc +from datetime import datetime, timezone +import requests +from app.routes.routes_helper_utilities import create_model_inst_from_dict_with_response, retrieve_model_inst_by_id +from app.models.task import Task +from app.db import db +import os + +slack_token = os.environ.get("SLACKBOT_TOKEN") + +bp = Blueprint("task_bp", __name__, url_prefix="/tasks") + + +# CREATE ONE TASK +@bp.post("") +def create_task(): + request_body = request.get_json() + return create_model_inst_from_dict_with_response(Task, request_body) + + +# READ ALL TASKS +@bp.get("") +def get_all_tasks(): + query = db.select(Task) + + sort_param = request.args.get("sort") + if sort_param=="desc": + query = query.order_by(desc(Task.title)) + else: + query = query.order_by(Task.title) + + query = query.order_by(Task.id) + tasks = db.session.scalars(query) + + response = [] + for task in tasks: + response.append(task.to_dict()) + + return response + + +# READ ONE TASK BY ID +@bp.get("/") +def get_task_by_id(task_id): + task = retrieve_model_inst_by_id(Task, task_id) + + return {"task": task.to_dict()} + + +# UPDATE ONE TASK +@bp.put("/") +def update_by_id(task_id): + task = retrieve_model_inst_by_id(Task, task_id) + request_body = request.get_json() + + task.title = request_body["title"] + task.description = request_body["description"] + + db.session.commit() + + return Response(status=204, mimetype="application/json") + + +# PATCH ONE TASK +@bp.patch("/") +def patch_by_id(task_id): + task = retrieve_model_inst_by_id(Task, task_id) + request_body = request.get_json() + + if "title" in request_body: + task.title = request_body["title"] + if "description" in request_body: + task.description = request_body["description"] + if "completed_at" in request_body: + task.completed_at = request_body["completed_at"] + + db.session.commit() + + return Response(status=204, mimetype="application/json") + + +# PATCH ONE TASK MARK IT AS COMPLETE +@bp.patch("//mark_complete") +def patch_by_id_mark_complete(task_id): + task = retrieve_model_inst_by_id(Task, task_id) + + task.completed_at = datetime.now(timezone.utc) + db.session.commit() + + # send notification to Slack + headers = {"Authorization": f"Bearer {slack_token}"} + data = { + "channel": "C08NTC26TM1", + "text": f"Someone just completed the task -- {task.title}: {task.description}" + } + + requests.post("https://slack.com/api/chat.postMessage", headers=headers, data=data) + + return Response(status=204, mimetype="application/json") + + +# PATCH ONE TASK MARK IT AS INCOMPLETE +@bp.patch("//mark_incomplete") +def patch_by_id_mark_incomplete(task_id): + task = retrieve_model_inst_by_id(Task, task_id) + + task.completed_at = None + db.session.commit() + + return Response(status=204, mimetype="application/json") + + +# DELETE ONE TASK +@bp.delete("/") +def delete_by_id(task_id): + task = retrieve_model_inst_by_id(Task, task_id) + + db.session.delete(task) + db.session.commit() + + return Response(status=204, mimetype="application/json") + + +# DELETE ALL TASKS +@bp.delete("") +def delete_all_tasks(): + db.session.query(Task).delete() + db.session.commit() + + return Response(status=204, mimetype="application/json") diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..0e0484415 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Single-database configuration for Flask. diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..ec9d45c26 --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,50 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic,flask_migrate + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[logger_flask_migrate] +level = INFO +handlers = +qualname = flask_migrate + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..4c9709271 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,113 @@ +import logging +from logging.config import fileConfig + +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + + +def get_engine(): + try: + # this works with Flask-SQLAlchemy<3 and Alchemical + return current_app.extensions['migrate'].db.get_engine() + except (TypeError, AttributeError): + # this works with Flask-SQLAlchemy>=3 + return current_app.extensions['migrate'].db.engine + + +def get_engine_url(): + try: + return get_engine().url.render_as_string(hide_password=False).replace( + '%', '%%') + except AttributeError: + return str(get_engine().url).replace('%', '%%') + + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option('sqlalchemy.url', get_engine_url()) +target_db = current_app.extensions['migrate'].db + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def get_metadata(): + if hasattr(target_db, 'metadatas'): + return target_db.metadatas[None] + return target_db.metadata + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=get_metadata(), literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + conf_args = current_app.extensions['migrate'].configure_args + if conf_args.get("process_revision_directives") is None: + conf_args["process_revision_directives"] = process_revision_directives + + connectable = get_engine() + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=get_metadata(), + **conf_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/5e99fa03d6f6_add_goal_id_column_to_task_model.py b/migrations/versions/5e99fa03d6f6_add_goal_id_column_to_task_model.py new file mode 100644 index 000000000..6f3130b09 --- /dev/null +++ b/migrations/versions/5e99fa03d6f6_add_goal_id_column_to_task_model.py @@ -0,0 +1,34 @@ +"""add goal_id column to Task model + +Revision ID: 5e99fa03d6f6 +Revises: 6c80ec5add5b +Create Date: 2025-05-08 12:58:20.334951 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '5e99fa03d6f6' +down_revision = '6c80ec5add5b' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.add_column(sa.Column('goal_id', sa.Integer(), nullable=True)) + batch_op.create_foreign_key(None, 'goal', ['goal_id'], ['id']) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.drop_constraint(None, type_='foreignkey') + batch_op.drop_column('goal_id') + + # ### end Alembic commands ### diff --git a/migrations/versions/6c80ec5add5b_.py b/migrations/versions/6c80ec5add5b_.py new file mode 100644 index 000000000..94bed6fbd --- /dev/null +++ b/migrations/versions/6c80ec5add5b_.py @@ -0,0 +1,32 @@ +"""empty message + +Revision ID: 6c80ec5add5b +Revises: c62b77d928bc +Create Date: 2025-05-07 21:32:10.034895 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '6c80ec5add5b' +down_revision = 'c62b77d928bc' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.add_column(sa.Column('title', sa.String(), nullable=False)) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.drop_column('title') + + # ### end Alembic commands ### diff --git a/migrations/versions/8269bc9c305b_.py b/migrations/versions/8269bc9c305b_.py new file mode 100644 index 000000000..4ffbe850c --- /dev/null +++ b/migrations/versions/8269bc9c305b_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: 8269bc9c305b +Revises: +Create Date: 2025-05-01 18:13:34.013500 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '8269bc9c305b' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/c62b77d928bc_.py b/migrations/versions/c62b77d928bc_.py new file mode 100644 index 000000000..c23815ef3 --- /dev/null +++ b/migrations/versions/c62b77d928bc_.py @@ -0,0 +1,31 @@ +"""empty message + +Revision ID: c62b77d928bc +Revises: 8269bc9c305b +Create Date: 2025-05-01 18:30:25.278797 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'c62b77d928bc' +down_revision = '8269bc9c305b' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index 55475db79..33dc7bc90 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -3,7 +3,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -14,7 +14,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -33,7 +33,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -52,7 +52,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,14 +60,14 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"message": "Task with id <1> is not found."} + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -97,7 +97,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -117,7 +117,7 @@ def test_update_task(client, one_task): -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -128,14 +128,14 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"message": "Task with id <1> is not found."} + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -146,7 +146,7 @@ def test_delete_task(client, one_task): query = db.select(Task).where(Task.id == 1) assert db.session.scalar(query) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -154,8 +154,8 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"message": "Task with id <1> is not found."} + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** @@ -163,7 +163,7 @@ def test_delete_task_not_found(client): assert db.session.scalars(db.select(Task)).all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -180,7 +180,7 @@ def test_create_task_must_contain_title(client): assert db.session.scalars(db.select(Task)).all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index d7d441695..d02b266eb 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -6,7 +6,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -34,7 +34,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert db.session.scalar(query).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -46,7 +46,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert db.session.scalar(query).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -74,7 +74,7 @@ def test_mark_complete_on_completed_task(client, completed_task): query = db.select(Task).where(Task.id == 1) assert db.session.scalar(query).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -86,7 +86,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert db.session.scalar(query).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -94,14 +94,15 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "Task with id <1> is not found."} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -109,8 +110,9 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "Task with id <1> is not found."} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index 222d10cf0..a02bd3c9d 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,9 @@ +from app.models.goal import Goal +from app.db import db import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +14,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +31,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +48,24 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): - pass + # pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # raise Exception("Complete test") # Assert # ---- Complete Test ---- # assertion 1 goes here + assert response_body["message"] == "Goal with id <1> is not found." # assertion 2 goes here + assert response.status_code == 404 # ---- Complete Test ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +84,43 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- - - # Assert + response = client.put("/goals/1", json={"title": "Updated Goal Title"}) # Assert # ---- Complete Assertions Here ---- # assertion 1 goes here + assert response.status_code == 204 + + query = db.select(Goal).where(Goal.id == 1) + goal = db.session.scalar(query) + # assertion 2 goes here + assert goal.title == "Updated Goal Title" # assertion 3 goes here + assert goal.id == 1 # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act + response = client.put("/goals/1", json={"title": "Updated Goal Title"}) # Assert + response_body = response.get_json() # ---- Complete Act Here ---- - # Assert # ---- Complete Assertions Here ---- # assertion 1 goes here + assert response.status_code == 404 # assertion 2 goes here + assert response_body == {"message": "Goal with id <1> is not found."} # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -121,28 +134,33 @@ def test_delete_goal(client, one_goal): response_body = response.get_json() assert "message" in response_body - - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** + assert response_body == {"message": "Goal with id <1> is not found."} # ***************************************************************** -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- - + response = client.delete("/goals/1") # Assert # ---- Complete Assertions Here ---- # assertion 1 goes here + assert response.status_code == 404 + + response_body = response.get_json() # assertion 2 goes here + assert response_body == {"message": "Goal with id <1> is not found."} + # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 0317f835a..f38661c0b 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -3,8 +3,8 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") -def test_post_task_ids_to_goal(client, one_goal, three_tasks): +# @pytest.mark.skip(reason="No way to test this feature yet") +def test_post_task_ids_to_goal(client, one_goal, three_tasks): # why we replace task 1 # Act response = client.post("/goals/1/tasks", json={ "task_ids": [1, 2, 3] @@ -25,7 +25,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(db.session.scalar(query).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -45,7 +45,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(db.session.scalar(query).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -54,13 +54,14 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** + assert response_body["message"] == "Goal with id <1> is not found." # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -77,7 +78,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -102,7 +103,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()