Kristina - Leaves #45
Open
krismosk wants to merge 1 commit into
Open
Conversation
CheezItMan
reviewed
Mar 10, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Stack is working fine, but you have some issues with Queue. Take a look at my comments and let me know what questions you have.
Comment on lines
3
to
5
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def balanced(string) |
There was a problem hiding this comment.
The method works, time and space complexity?
Comment on lines
+11
to
+14
| end | ||
|
|
||
| if @front == @back | ||
| end |
There was a problem hiding this comment.
Suggested change
| end | |
| if @front == @back | |
| end | |
| elsif @front == @back | |
| # Raise an error if the Queue is full | |
| end |
| def dequeue | ||
| raise NotImplementedError, "Not yet implemented" | ||
| if @front == @back | ||
| return "queue is empty" |
There was a problem hiding this comment.
It would be better to raise an error in this circumstance.
| data = @store[@front] | ||
| @store[@front] = nil | ||
|
|
||
| if @front == @back |
There was a problem hiding this comment.
I think you need to advance front before comparing it to back.
Comment on lines
+48
to
+50
| if @front == @back | ||
| return true | ||
| end |
There was a problem hiding this comment.
Suggested change
| if @front == @back | |
| return true | |
| end | |
| return @front == @back |
| end | ||
|
|
||
| def to_s | ||
| @store.delete(nil) |
There was a problem hiding this comment.
This will shrink the internal array. It's both an expensive operation and it will also not maintain the order of elements in the Queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions