Angele Z.#41
Open
geli-gel wants to merge 5 commits into
Open
Conversation
CheezItMan
reviewed
Mar 3, 2020
CheezItMan
left a comment
There was a problem hiding this comment.
Well you have most of the Stack class working, with one error, otherwise nice work. If you add any methods to Queue and want me to look over it, ping me in Slack and I'll give additional feedback.
I would have liked to see at least dequeue attempted.
| @@ -26,6 +40,13 @@ def empty? | |||
| end | |||
|
|
|||
| def to_s | |||
|
|
||
| def empty? | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @store ? true : false |
There was a problem hiding this comment.
This should probably be:
Suggested change
| return @store ? true : false | |
| return @store.empty? |
Because @store is an instance of LinkedList and won't be nil.
| @@ -1,12 +1,26 @@ | |||
| class Queue | |||
There was a problem hiding this comment.
Just noting dequeue and size are not implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation