Skip to content

Sockets - Sarah#41

Open
sjscotton wants to merge 10 commits into
Ada-C11:masterfrom
sjscotton:master
Open

Sockets - Sarah#41
sjscotton wants to merge 10 commits into
Ada-C11:masterfrom
sjscotton:master

Conversation

@sjscotton
Copy link
Copy Markdown

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar
Give one example where you choose Flexbox over Grid
Where did you choose to use CSS Grid and why did you make that decision
What was the hardest part of this assignment, and why was it difficult
What concept did you get the most clarity on through Startrly?

Copy link
Copy Markdown

@dev-elle-up dev-elle-up left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! I love the colors and the style overall. Also your code is dry and easy to read. Great work.

Comment thread index.css
}
.tagline {
background: #57BC90;
display: grid;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of grid on the tagline section!

Comment thread index.css
@@ -0,0 +1,149 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider using grid for the overall structure?

Comment thread index.css
}

.flexbox li {
flex: 1;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I hadn't seen before. Thanks for the learning moment. :-)

Comment thread index.css
}

.sponsers .flexbox, .team-members .flexbox {
justify-content: space-around;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sponsors are almost touching on my browser. Was this a design choice or a browser rendering? It could be nice to give these elements a little margin. (or not)

Comment thread index.css
flex-direction: column;
}

.team-members .flexbox li img {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you did a great job of naming everything! It made it very easy to read your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants